Project

General

Profile

Actions
Copy link

Bug #10259

closed

[CWL] Submitted pipelines don't finish

Added by Peter Amstutz about 8 years ago. Updated about 8 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Peter Amstutz
Category:
-
Target version:
2016-10-26 sprint
Start date:
10/13/2016
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Description

Pipelines submitted from arvados-cwl-runner don't finish, because they are submitted as RunningOnClient. Fix this so that pipelines submitted this way are RunningOnServer so that arv-run-pipeline-instance will ensure that the pipeline is marked as completed.

Subtasks 3 (0 open — 3 closed)

Task #10286: Review 10259-cwl-pipeline-nullResolvedPeter Amstutz10/13/2016

Actions
Task #10271: Review 10259-cwl-pipeline-valueResolvedPeter Amstutz10/13/2016

Actions
Task #10260: Review 10259-cwl-pipelineResolvedRadhika Chippada10/13/2016

Actions
Actions
Copy link
 #1

Updated by Peter Amstutz about 8 years ago

  • Description updated (diff)
  • Assigned To set to Peter Amstutz
  • Story points set to 0.5
Actions
Copy link
 #2

Updated by Peter Amstutz about 8 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #3

Updated by Radhika Chippada about 8 years ago

LGTM

Actions
Copy link
 #4

Updated by Peter Amstutz about 8 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:82cd0096558b94f8ff1e23d6e3f8b8dfec7df7b9.

Actions
Copy link
 #5

Updated by Peter Amstutz about 8 years ago

  • Status changed from Resolved to In Progress
Actions
Copy link
 #6

Updated by Lucas Di Pentima about 8 years ago

10259-cwl-pipeline-value @ 1825696494802d264c74ed2af58cc39b6ff8c7f8 LGTM

Actions
Copy link
 #7

Updated by Peter Amstutz about 8 years ago

One more branch @ 10259-cwl-pipeline-null. Passes 100% CWL conformance tests for me on arvbox.

Actions
Copy link
 #8

Updated by Lucas Di Pentima about 8 years ago

I think I spotted a small typo that don't get to be tested:

  • sdk/cli/bin/arv-run-pipeline-instance:381: I think has_key(...) should be has has_key?(...) as used at line 369.
Actions
Copy link
 #9

Updated by Lucas Di Pentima about 8 years ago

Apart from that typo, lgtm.

Actions
Copy link
 #10

Updated by Peter Amstutz about 8 years ago

  • Status changed from In Progress to Resolved

I think the fallout from this ticket has been resolved, so marking resolved.

Actions
Copy link

Also available in: Atom PDF