Story #10343: [dockercleaner] mandatory config - Arvados

Actions

Copy link

Story #10343

closed

[dockercleaner] mandatory config

Added by Nico César about 8 years ago. Updated about 8 years ago.

Status:

Resolved

Priority:

Normal

Assigned To:

Tom Clegg

Category:

Target version:

2016-11-09 sprint

Start date:

10/25/2016

Due date:

% Done:

100%

Estimated time:

(Total: 0.00 h)

Story points:

0.5

Description

after #9953 was done, there is a mandatory config for dockercleaner.

Make this non-mandatory

Please add examples in the installation guide.

Subtasks 1 (0 open — 1 closed)

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Tom Morris about 8 years ago

Assigned To set to Tom Clegg
Target version set to 2016-11-09 sprint
Story points set to 0.5
Tracker changed from Bug to Story
Description updated (diff)

Actions

Copy link

Updated by Tom Clegg about 8 years ago

Status changed from New to In Progress

The packaged systemd unit file seems to be incompatible with Centos7, because of the Python3-via-Software-Collections arrangement.

Also, the arvados-docker-cleaner package seems to have undeclared dependencies on python3-pkg-resources and the python3 meta/wrapper package.

With debian:8...

root@2e901b1c1678:/# apt-get install arvados-docker-cleaner
root@2e901b1c1678:/# arvados-docker-cleaner --help
bash: /usr/bin/arvados-docker-cleaner: /usr/bin/python3: bad interpreter: No such file or directory
root@2e901b1c1678:/# apt-get install python3
root@2e901b1c1678:/# arvados-docker-cleaner --help
Traceback (most recent call last):
  File "/usr/bin/arvados-docker-cleaner", line 5, in <module>
    from pkg_resources import load_entry_point
ImportError: No module named 'pkg_resources'
root@2e901b1c1678:/# apt-get install python3-pkg-resources
root@2e901b1c1678:/# arvados-docker-cleaner --help
usage: arvados_docker.cleaner [-h] [--config CONFIG] [--quota QUOTA]
...

Actions

Copy link

Updated by Tom Clegg about 8 years ago

10343-dockercleaner-config

test 246413f02ca8711f117a8575fccfec82e5dbfe23

Actions

Copy link

Updated by Nico César about 8 years ago

review at 246413f02ca8711f117a8575fccfec82e5dbfe23

~$ <span class="userinput">sudo cp /usr/share/doc/arvados-docker-cleaner/arvados-docker-cleaner.service /lib/systemd/system/</span>

<span class="userinput">sudo cp /opt/rh/python33/root/usr/share/doc/arvados-docker-cleaner/arvados-docker-cleaner.service /lib/systemd/system/</span>
$ <span class="userinput">sudo nano /lib/systemd/system/arvados-docker-cleaner.service</span>

User files (not the ones provided by the package are in / etc /systemd/system

The package should include /lib/systemd/system/arvados-docker-cleaner.service and if the user wants to make modifications will copy it to /etc/systemd/system/arvados-docker-cleaner.service

having .service in /usr/share/doc/ is unnatural for the sysadmin

also every DEPRECATED message should help the sysadmin to DTRT

            logger.warning("DEPRECATED: default config file not found; " 
                           "relying on command line configuration")

should be

            logger.warning("DEPRECATED: default config file '{}' not found; " 
                           "relying on command line configuration".format(DEFAULT_CONFIG_FILE)

Actions

Copy link

Updated by Tom Clegg about 8 years ago

Updated log message.

Updated/rewrote postinst scripts so our Go & Python unit files get installed/enabled/started automatically in Red Hat, too.

test 4e9fd075b8136613e7edbb0465bcb96ccf5b1f45

Actions

Copy link

Updated by Nico César about 8 years ago

test 4e9fd075b8136613e7edbb0465bcb96ccf5b1f45

I notice the in services/dockercleaner/arvados-docker-cleaner.service the ExecStart somehow complicated as follows:

ExecStart=/bin/sh -c 'if [ -e /opt/rh/python33/root/bin/arvados-docker-cleaner ]; then exec scl enable python33 arvados-docker-cleaner; else exec arvados-docker-cleaner; fi'

Which I'm aware that is because of Software Collections + SystemD and some other things. I'm not suggesting to change it But we should have a comment that explains why the complexity or points to a public URL explaining why...

I know Red Hat's guide is different on this subject:
https://access.redhat.com/documentation/en-US/Red_Hat_Software_Collections/1/html/Packaging_Guide/sect-Software_Collection_Initscript_Support.html

But I think we're good to go with it...

Actions

Copy link