Bug #11014: [Workbench] Hide the "idle/busy nodes" part of the dashboard if crunch1 APIs are disabled - Arvados

Actions

Copy link

Bug #11014

closed

[Workbench] Hide the "idle/busy nodes" part of the dashboard if crunch1 APIs are disabled

Added by Tom Clegg almost 8 years ago. Updated almost 8 years ago.

Status:

Resolved

Priority:

Normal

Assigned To:

Lucas Di Pentima

Category:

Target version:

2017-03-29 sprint

Start date:

03/17/2017

Due date:

% Done:

100%

Estimated time:

(Total: 0.00 h)

Story points:

0.5

Subtasks 1 (0 open — 1 closed)

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Tom Morris almost 8 years ago

Story points set to 0.5

Actions

Copy link

Updated by Tom Morris almost 8 years ago

Target version set to 2017-03-29 sprint

Actions

Copy link

Updated by Lucas Di Pentima almost 8 years ago

Assigned To set to Lucas Di Pentima

Actions

Copy link

Updated by Lucas Di Pentima almost 8 years ago

Status changed from New to In Progress

Actions

Copy link

Updated by Lucas Di Pentima almost 8 years ago

Updates on branch 11014-hide-node-status at 73dbf5b
Tests run at: https://ci.curoverse.com/job/developer-run-tests/191/

Used the already existing ArvadosBase.api_exists?() method on the dashboard template partial to decide whether to render or not the compute node status pane.

Actions

Copy link

Updated by Lucas Di Pentima almost 8 years ago

Re-ran the tests here: https://ci.curoverse.com/job/developer-run-tests/192/

Actions

Copy link

Updated by Radhika Chippada almost 8 years ago

Rather than executing “PipelineInstance.api_exists?” multiple times, can we declare a variable such as “show_node_status” at line 30?

This I am not sure if you would like to address or not, but I’d mention it. If NOT PipelineInstance.api_exists? AND NOT Rails.configuration.show_recent_collections_on_dashboard, the left pane that shows processes is squished to the left half. It looked really bad! Should we declare panel_width = 6 or 12 before line 37 depending on this IF condition and use it at lines 38 and 98?
```
div class="col-md-6"
```