Bug #11679: [Workbench] Logs containers with undefined exit code - Arvados

Actions

Copy link

Bug #11679

open

[Workbench] Logs containers with undefined exit code

Added by Peter Amstutz about 7 years ago. Updated almost 3 years ago.

Status:

New

Priority:

Normal

Assigned To:

Tom Clegg

Category:

Target version:

Start date:

Due date:

% Done:

Estimated time:

Story points:

Description

Workbench logs container state change messages. When a container is complete, it looks at the exit code and reports success or failure. However, for some reason, the exit code is reported as undefined, which is not zero, and it reports failure (I've seen this with both exit code 1 and exit code 0):

2017-05-11T14:12:36.420834199Z Waiting for container to finish
2017-05-11T14:18:49.777935199Z Container exited with code: 1
2017-05-11T14:18:49.993315999Z Complete
2017-05-11T14:18:50.791787Z Container qr1hi-dz642-hre34ora0zbr9k1 finished with exit code undefined (failure)

Actions

Copy link

Updated by Peter Amstutz about 7 years ago

Subject changed from [Workbench] Logs completed containers as failed to [Workbench] Logs containers with undefined exit code
Description updated (diff)

Actions

Copy link

Updated by Tom Clegg about 7 years ago

arvados-ws sends properties.new_attributes.state but does not send properties.new_attributes.exit_code; see sendObjectAttributes in source:services/ws/session_v0.go.

Workbench assumes the update event will include exit_code if it includes state=Complete; see source:apps/workbench/app/assets/javascripts/work_unit_log.js.

Actions

Copy link