Bug #12316
closed
[Workbench] deletion of data collections destroying the provenance graph - rendering crashes
100%
Description
Test case:
https://workbench.9tee4.arvadosapi.com/container_requests/9tee4-xvhdp-j0022f2t2b8w4ya#ProvenanceThe PDH of the input collection no longer exists.
Updated by Ward Vandewege about 7 years ago
- Subject changed from [Workbench] deletion of data collections destroying the provenance graph - rendering crashes to [Workbench] deletion of data collections destroying the provenance graph - rendering crashes
- Description updated (diff)
Updated by Ward Vandewege about 7 years ago
I have a fix for this bug in branch 12316-fix-provenance-graph at 5098820fed0920a31dd87a12c4f027318d7a1bd6
Updated by Ward Vandewege about 7 years ago
- Target version set to 2017-09-27 Sprint
Updated by Ward Vandewege about 7 years ago
- Status changed from New to In Progress
Updated by Lucas Di Pentima about 7 years ago
This LGTM. Just one idea: would it be nice to also notify the user that the collection is deleted to minimize the surprise effect? Maybe adding '(deleted)' to the graph node's name could be enough.
Updated by Ward Vandewege about 7 years ago
- Status changed from In Progress to Resolved
Lucas Di Pentima wrote:
This LGTM. Just one idea: would it be nice to also notify the user that the collection is deleted to minimize the surprise effect? Maybe adding '(deleted)' to the graph node's name could be enough.
Done in 3895b3adf05dc6c8d7b66e6bdd42e576a03b1f09.
I've merged this, thanks!
Updated by Tom Morris about 7 years ago
Thanks for the quick fix! 6 hours from report to fix and <12 hours to merge. Don't forget to prepare to demo at sprint review :-)
Point of clarification for those following along in the distant future -- PDHs never cease to exist. They might not be resolvable to a collection (or they might resolve to multiple collections), but they always exist (says pedantic Tom).