Feature #13431: [keepproxy] [GoSDK] Propagate desired storage classes in PUT request headers - Arvados

Actions

Copy link

Feature #13431

closed

[keepproxy] [GoSDK] Propagate desired storage classes in PUT request headers

Added by Tom Clegg over 6 years ago. Updated over 6 years ago.

Status:

Resolved

Priority:

Normal

Assigned To:

Lucas Di Pentima

Category:

Target version:

2018-06-06 Sprint

Start date:

06/05/2018

Due date:

% Done:

100%

Estimated time:

(Total: 0.00 h)

Story points:

1.0

Release:

Arvados 1.2

Release relationship:

Auto

Description

Add storage classes support to Keepclient
If a client request includes the ‘X-Keep-Storage-Class’ header, use the newly added keepclient feature.

Subtasks 1 (0 open — 1 closed)

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Tom Clegg over 6 years ago

Blocks Feature #11184: [Keep] Support multiple storage classes added

Actions

Copy link

Updated by Tom Morris over 6 years ago

Target version set to To Be Groomed

Actions

Copy link

Updated by Lucas Di Pentima over 6 years ago

Description updated (diff)

Actions

Copy link

Updated by Tom Clegg over 6 years ago

Story points set to 1.0

Actions

Copy link

Updated by Lucas Di Pentima over 6 years ago

Subject changed from [keepproxy] [Go] Propagate desired storage classes in PUT request headers to [keepproxy] [GoSDK] Propagate desired storage classes in PUT request headers
Description updated (diff)

Actions

Copy link

Updated by Tom Morris over 6 years ago

Target version changed from To Be Groomed to Arvados Future Sprints

Actions

Copy link

Updated by Tom Morris over 6 years ago

Target version changed from Arvados Future Sprints to 2018-06-06 Sprint

Actions

Copy link

Updated by Lucas Di Pentima over 6 years ago

Assigned To set to Lucas Di Pentima

Actions

Copy link

Updated by Lucas Di Pentima over 6 years ago

Status changed from New to In Progress

Actions

Copy link

#10

Updated by Lucas Di Pentima over 6 years ago

Updates at dd97299b6 - branch 13431-keepproxy-storage-classes-headers
Test run: https://ci.curoverse.com/job/developer-run-tests/735/

Added keepclient & keepproxy support for storage classes

I'm not sure how to write tests for keepproxy. Should I write some kind of keepstore fake server to be able to read requests coming from keepproxy?

Actions

Copy link

#11

Updated by Tom Clegg over 6 years ago

LGTM

For keepproxy testing, you could use httptest.NewServer() to make a keepstore stub that just stashes the request headers and responds 500, make keepproxy connect to the stub using the same approach as TestAskGetKeepProxyConnectionError(), then check that the expected header was received.

Actions

Copy link

#12

Updated by Lucas Di Pentima over 6 years ago

Updates at 7b7950766
Test run: https://ci.curoverse.com/job/developer-run-tests/737/

Added test that confirms X-Keep-Storage-Classes header propagation
Fixed TestAskGetKeepProxyConnectionError test, which wasn't testing keepproxy, but keepclient.

Actions

Copy link

#13