Bug #13920: arvados-cli fails with ruby versions >= 2.3.7 - Arvados

Actions

Copy link

Bug #13920

closed

arvados-cli fails with ruby versions >= 2.3.7

Added by Lucas Di Pentima over 6 years ago. Updated about 6 years ago.

Status:

Resolved

Priority:

Normal

Assigned To:

Lucas Di Pentima

Category:

SDKs

Target version:

2018-08-01 Sprint

Start date:

07/26/2018

Due date:

% Done:

100%

Estimated time:

(Total: 0.00 h)

Story points:

Release:

Arvados 1.2

Release relationship:

Auto

Description

When using arvados-cli with ruby 2.3.7 or above, it errors out with the following error message:

Failed to connect to Arvados API server: header field value cannot include CR/LF

Subtasks 1 (0 open — 1 closed)

Related issues 3 (0 open — 3 closed)

Actions

Copy link

Updated by Lucas Di Pentima over 6 years ago

The issue is caused by the fact that newer versions of Ruby don't accept \n on header fields, and the google-api-client gem we're using sometimes adds it.

One option is to upgrade the google-api-client gem to version 0.20.0 or above (see https://github.com/google/google-api-ruby-client/pull/648/commits/ee8c922dbf9cef79284d4b83d16d4d73008a6e8f) but that's isn't trivial because from version 0.9 onwards, this gem significantly changed its way of working, and it's not compatible with our arvados gem.

The other option would be to monkeypatch the google-api-client gem from our own arvados gem.

Actions

Copy link

Updated by Lucas Di Pentima over 6 years ago

Updates at c0b02133b - branch 13920-arvados-gem-with-newer-rubies
Test run: https://ci.curoverse.com/job/developer-run-tests/828/

Monkeypatch google-api-client after requiring it on the arvados gem.

Actions

Copy link

Updated by Lucas Di Pentima over 6 years ago

How to test:

1. Build the new arvados gem
2. With rvm install ruby 2.3.7 or 2.4.4
3. Create a gemset and install the newly created arvados gem and then install arvados-cli gem
4. Set up vars to access some arvados instance
5. Execute "arv user current", it should work without issues.