Bug #15496
closed
[Workbench] Group membership doesn't work on User admin page
Added by Lucas Di Pentima over 5 years ago.
Updated over 5 years ago.
Estimated time:
(Total: 0.00 h)
Release relationship:
Auto
Description
When clicking user → group or group → user checkboxes, no request is being made to the server. On the Javascript console there's an error that can provide some clue:
0: "Error: no data-permission-uuid established here."
1: input#group_uuids_
length: 2
__proto__: Array(0)
Comparing versions 1.3.3 against 1.4 or master, seems that rails' check_box_tag() template function is ignoring attributes with values being nil, in this case when a checkbox is rendered unchecked, its data-permission-uuid attribute should have "null" as its value, but it isn't there and the javascript click handler returns with the observed error message.
Updates at 431f22982 - branch 15496-wb1-group-membership-admin
Test run: https://ci.curoverse.com/job/developer-run-tests/1431/
Sets up a default 'x' value on data-permission-uuid instead of relying on rails' tag helper that from rails 5.0 seems to ignore attributes with falsy values.
As we have been having flakyness with the wb1's integration test suite, didn't think it's a good time investment to write a test for this as we're phasing workbench1, but I can do it if necessary.
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
- Release changed from 26 to 27
Also available in: Atom
PDF
Updated by 
Updated by Tom Morris 
Updated by