Actions
Story #15922
closed
Change EnableBetaController14287 (default false) to ForceLegacyAPI14 (default false)
Start date:
12/12/2019
Due date:
% Done:
100%
Estimated time:
(Total: 0.00 h)
Story points:
0.5
Release:
Release relationship:
Auto
Updated by Tom Clegg about 5 years ago
- Related to Story #14287: [Controller] Refactor API code / routing added
Updated by Tom Clegg about 5 years ago
- Subject changed from Change EnableBetaController14287 (default false) to ForceRailsAPI (default false) to Change EnableBetaController14287 (default false) to ForceLegacyAPI14 (default false)
Updated by Tom Clegg about 5 years ago
- Status changed from New to In Progress
- Assigned To set to Tom Clegg
Updated by Tom Clegg about 5 years ago
15922-force-legacy-api-14 @ commit:eb3ff279c7f29745ff9a9a48288ef07731c812a9 -- https://ci.curoverse.com/view/Developer/job/developer-run-tests/1692/
Updated by Tom Clegg about 5 years ago
15922-force-legacy-api-14 @ 44f0586f6d2feb1325e1b5f2014195506c03f48a -- https://ci.curoverse.com/view/Developer/job/developer-run-tests/1695/
Updated by Lucas Di Pentima about 5 years ago
Just a couple of comments, otherwise LGTM:
- Should the controller log a warning when the flag is true reminding the admin that will be deprecated?
- Do you think adding a test for existence of
writable_byon responses would be useful? Asking becauseetaggot one but I believe the other didn’t.
Updated by Tom Clegg about 5 years ago
I'm reluctant to warn about something the admin had to do explicitly after (presumably) reading the caveats in the config file comment. The config loader will warn automatically ("unknown config key") if it's still in the config when the flag is removed/unsupported.
Yes to a writable_by test. Added to 15922-force-legacy-api-14 @ 1c4a2d386dc0d2a85c86171801c6681d76fb12fe
Updated by Tom Clegg about 5 years ago
- Status changed from In Progress to Resolved
Actions