Feature #16106
closed
[arvados-dispatch-cloud] Azure driver support for preemptible instances
Added by Tom Clegg almost 5 years ago.
Updated almost 4 years ago.
Estimated time:
(Total: 0.00 h)
Release relationship:
Auto
Description
When creating instances, source:lib/cloud/azure should create a preemptible instance if the instance type's Preemptible flag is set.
arvados-dispatch-cloud already knows how to choose a preemptible type if the container's scheduling_constraints want one; see ChooseInstanceType() in source:lib/dispatchcloud/node_size.go
- Related to Story #13908: [Epic] Replace SLURM for cloud job scheduling/dispatching added
- Target version set to To Be Groomed
- Target version deleted (
To Be Groomed)
- Target version set to 2020-10-21 Sprint
- Target version changed from 2020-10-21 Sprint to 2020-11-04 Sprint
- Target version changed from 2020-11-04 Sprint to 2020-10-21 Sprint
- Status changed from New to In Progress
- Assigned To set to Ward Vandewege
- Target version changed from 2020-10-21 Sprint to 2020-11-04 Sprint
- Target version changed from 2020-11-04 Sprint to 2020-11-18
- Target version changed from 2020-11-18 to 2020-12-02 Sprint
- Target version changed from 2020-12-02 Sprint to 2020-12-16 Sprint
- Target version changed from 2020-12-16 Sprint to 2021-01-06 Sprint
- Target version changed from 2021-01-06 Sprint to 2021-01-20 Sprint
- Related to Feature #17249: Make costanalyzer aware of preemptable instances added
Preemptible is misspelled "[Pp]reemptable" a couple of times on doc page.
Nit: In source:lib/cloud/azure/azure.go I think it would be good form to put the maxPrice var inside the if{} block ("var maxPrice float64 = 1" or "maxPrice := float64(-1)") - especially since we're storing a pointer to it, using it later would be wrong (and admittedly unlikely).
Rest LGTM. Thanks!
Tom Clegg wrote:
Preemptible is misspelled "[Pp]reemptable" a couple of times on doc page.
Nit: In source:lib/cloud/azure/azure.go I think it would be good form to put the maxPrice var inside the if{} block ("var maxPrice float64 = 1" or "maxPrice := float64(-1)") - especially since we're storing a pointer to it, using it later would be wrong (and admittedly unlikely).
Rest LGTM. Thanks!
Great, nice catch, both changes made, and merged.
- Status changed from In Progress to Resolved
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by