Feature #16319
closed
packer build for jenkins images updated to use arvados-server install
Added by Peter Amstutz over 4 years ago.
Updated about 4 years ago.
Estimated time:
(Total: 0.00 h)
Release relationship:
Auto
Description
The gist of this is that the installation steps in:
packer/jenkins/run_jenkins-slave-image-run-tests.sh
should (as much as possible) be replaced with something like:
git clone https://git.arvados.org/arvados.git
cd arvados
go mod download
go run ./cmd/arvados-server install -type development
- Assigned To set to Javier Bértoli
- Target version changed from 2020-04-22 to 2020-05-06 Sprint
- Description updated (diff)
- Target version changed from 2020-05-06 Sprint to 2020-05-20 Sprint
- Assigned To changed from Javier Bértoli to Ward Vandewege
- Status changed from New to In Progress
Ready for review at commit:1a330c6a87b93349fabe10789f287707e3bab7ad on branch 16319-unify-build-dependencies in the packer repo.
- Target version changed from 2020-05-20 Sprint to 2020-06-03 Sprint
In
jenkins/node-ready.sh
In
jenkins/run_jenkins-slave-image-run-tests.sh
sudo go run ./cmd/arvados-server install -type development should be -type test (although they currently do the same thing)- Does "chown jenkins:jenkins arvados.git" really do anything useful, without
-R?
arvados-server install installs go binaries to /usr/local/bin/ so having a possibly-different version in /usr/bin/go might get confusing one day. Maybe delete "ln -s /usr/lib/go-1.14/bin/go /usr/bin/go" here, and invoke it explicitly as "/usr/lib/go-1.14/bin/go run ./cmd/arvados-server ..." instead?
Tom Clegg wrote:
In jenkins/node-ready.sh
- should probably add "set -eo pipefail", even if it means ignoring errors explicitly in some places (perhaps "systemctl enable ... || true" ?)
- the "nc" loop with RETVAL looks like it could be simplified to something like
[...]
- could DRY the /tmp/boot-wait.log stuff (copy all stdout and stderr to log) by putting this delightful bit of bash at the top:
[...]
In jenkins/run_jenkins-slave-image-run-tests.sh
sudo go run ./cmd/arvados-server install -type development should be -type test (although they currently do the same thing)- Does "chown jenkins:jenkins arvados.git" really do anything useful, without
-R?
arvados-server install installs go binaries to /usr/local/bin/ so having a possibly-different version in /usr/bin/go might get confusing one day. Maybe delete "ln -s /usr/lib/go-1.14/bin/go /usr/bin/go" here, and invoke it explicitly as "/usr/lib/go-1.14/bin/go run ./cmd/arvados-server ..." instead?
OK, everything incorporated at commit:14b4c53c0f4ae577da2c3b7ba71b824dfc05963d
- Status changed from In Progress to Resolved
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by