Story #16561
closed
Add "Listen" to Services config
Added by Peter Amstutz over 4 years ago.
Updated about 2 years ago.
Estimated time:
(Total: 0.00 h)
Release relationship:
Auto
Description
"InternalURLs" is used to provide the bind address but people expect it to mean a URL that is valid on the private network.
Add a "Listen" field which expresses the bind addresses that the server will use. Then "InternalURLs" can mean URLs that are valid on the private network.
- Description updated (diff)
- Description updated (diff)
- Related to Story #17667: Install docs explains InternalURL / ExternalURL, private networks & split DNS added
a possible approach: 16561-listen-address @ 3aac8e596 (rebased branch originally made during #17667)
- Related to Feature #18563: Simplify/streamline InternalURLs/ExternalURL situation added
- Target version set to 2022-05-25 sprint
- Target version changed from 2022-05-25 sprint to 2022-06-08 sprint
- Target version changed from 2022-06-08 sprint to 2022-06-22 Sprint
- Assigned To set to Tom Clegg
- Target version changed from 2022-06-22 Sprint to 2022-07-06
- Status changed from New to In Progress
A couple of questions:
- At
lib/service/cmd.go:L244 I find this use of conditionals somewhat hard to read, is there a reason to use it like that, other than saving indentation space?
- Do you think
getListenAddr() could benefit from a set of tests covering the different cases with/without the envvar, with/without ListenURL?
- Status changed from In Progress to Resolved
Applied in changeset arvados-private:commit:arvados|6b77f5f193b9c7e931d2e0b0712c1b27cd547fc8.
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by