Feature #16623
closed
Can reference compute subnet in different resource group on Azure
100%
Description
Currently the Network and Subnet for the NIC need to be in the same resource group as the NIC and VM will be created. Add a separate NetworkResourceGroup configuration option to allow referencing other Networks/Subnets when creating the virtual NIC.
Updated by Peter Amstutz over 4 years ago
- Subject changed from Can reference compute subnet in different resource group to Can reference compute subnet in different resource group on Azure
Updated by Peter Amstutz over 4 years ago
16623-azure-subnet @ 7cd9bca031fd0c319761fda7ff153283c35b7621
Updated by Lucas Di Pentima over 4 years ago
Reviewing 7cd9bca
- The update seems super trivial and looks good, but it would be nice to test the new fallback ResourceGroup selection mechanism, is that possible?
- I also browsed the docs and haven’t found a lot of info about setting up azure compute nodes, only what’s on https://doc.arvados.org/v2.0/install/install-dispatch-cloud.html. Would it be useful to mention this new config knob there?
Updated by Ward Vandewege over 4 years ago
- Status changed from Resolved to In Progress
- Target version changed from 2020-08-12 Sprint to 2020-08-26 Sprint
This patch was buggy. It did not remove NICs from the right resource group after the compute nodes are shut down.
A fix is ready for review in de4ad659335a24629934256fec6266842a47c2eb on branch 16623-a-d-c-compute-subnet-resource-group-azure-bugfix.
CI tests are at developer-run-tests: #2008
Updated by Peter Amstutz over 4 years ago
Ward Vandewege wrote:
This patch was buggy. It did not remove NICs from the right resource group after the compute nodes are shut down.
A fix is ready for review in de4ad659335a24629934256fec6266842a47c2eb on branch 16623-a-d-c-compute-subnet-resource-group-azure-bugfix.
CI tests are at developer-run-tests: #2008
The goal of the original fix was only to reference a virtual network in a different resource group, it doesn't need to create the virtual NICs there.
Updated by Peter Amstutz over 4 years ago
The NICs should still be created in the same resource group as the VMs, then the cleanup would still work.
Updated by Ward Vandewege over 4 years ago
- Status changed from In Progress to Resolved
Peter Amstutz wrote:
The NICs should still be created in the same resource group as the VMs, then the cleanup would still work.
Yes, you are right, I just tested it. Patch unnecessary and withdrawn, sorry about the noise.