Bug #16743
closedSome links do not work for wb2 v2.0.4
100%
Description
I'm having trouble with opening project links for arind since v2.0.4 was released, switching from wb to wb2 by changing the URL also gives a blank page, as well as opening a study after using the search, opening projects from the tree on the left works fine, though.
Updated by Peter Amstutz over 4 years ago
- Target version changed from 2020-08-26 Sprint to 2020-09-09 Sprint
Updated by Daniel Kutyła over 4 years ago
New version: https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/b71d59f7e1876c9eb20c2aa7c749c0acc8568b6f
Test run: developer-tests-workbench2: #79
Fixed case when parent project is undefined
Updated by Lucas Di Pentima over 4 years ago
- At file
src/views-components/side-panel-button/side-panel-button.tsx
line 62 there’s a debuggingconsole.log(1)
that can be removed. - I think the underlying problem is that I made a mistake by calling
isProjectTrashed()
withparentProj!
on line 63, overriding the protection of TS’s typing system, so maybe the more elegant solution would be to just not do a recursive call without checking ifparentProj
isundefined
, what do you think? If you don’t agree, I think it’s already OK but just wanted to avoid adding a fix over a type override error.
Updated by Daniel Kutyła over 4 years ago
New version: https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/a31a8fcb90d15b9810d36f4e3c8cb79b4e5f8ef9
Test run: developer-tests-workbench2: #81
Removed console.log's updated tests
Updated by Daniel Kutyła over 4 years ago
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
Applied in changeset arvados-workbench2|d7b47b1810da4b5c25013a14c29da0053e1d8206.