Bug #16956
closed
- Status changed from New to In Progress
- Description updated (diff)
Since we're on the subject, the {% comment %} block at the top gets rendered as #<Liquid::Comment:0x0000563905a15560>
We should either fix that, remove them (and exclude it from checking), or the SPDX-License-Identifier should just be part of the file as a normal Go/Python/YAML/whatever comment.
Also I noticed you touched install/install-compute-ping.html.textile.liquid but actually both that page file and the script it embeds to can be deleted entirely.
Should we make our version dependency on liquid more specific in the Gemfile? e.g. "~> 4.0.0"
Peter Amstutz wrote:
Should we make our version dependency on liquid more specific in the Gemfile? e.g. "~> 4.0.0"
Sure, done, as well as all the things from comments 5 and 6. Now at 75ddf9c801c1212d9ac0e674aff348a0f591bace on branch 16956-doc-fix-zenweb-liquid-4
Ward Vandewege wrote:
Peter Amstutz wrote:
Should we make our version dependency on liquid more specific in the Gemfile? e.g. "~> 4.0.0"
Sure, done, as well as all the things from comments 5 and 6. Now at 75ddf9c801c1212d9ac0e674aff348a0f591bace on branch 16956-doc-fix-zenweb-liquid-4
LGTM
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
- Release changed from 25 to 36
- Release changed from 36 to 25
Also available in: Atom
PDF