Feature #17499
closed
Workbench1 supports username/pw login
100%
Description
In order to fully eliminate the legacy SSO server, Workbench 1 needs to be able to support username/pw login for LDAP and PAM.
From discussion, the preferred solution will be to add a new username/password login page to Workbench 1.
Design:
- For LDAP, PAM and Test modes, the login page displays username and password entry
- Login button controller makes an AJAX call to "user authenticate" endpoint, providing username and password, and receiving API token or an error.
- Errors should redisplay the login page with a "login failed" message at the top (rails "flash" box)
Updated by Peter Amstutz over 3 years ago
- Target version changed from 2021-04-14 sprint to 2021-05-12 sprint
Updated by Peter Amstutz over 3 years ago
- Target version changed from 2021-05-12 sprint to 2021-05-26 sprint
Updated by Peter Amstutz over 3 years ago
17499-wb-login-form @ c426bf92611cff8b5590d5bf77359ea241d82dcb
- On the welcome page, now switches between "click here to log in" and basic username/password form based on configured login method.
- Javascript is shamelessly taken from login_testuser.go
- Replaced welcome text with Rails.configuration.Workbench.WelcomePageHTML
Updated by Peter Amstutz over 3 years ago
- Status changed from New to In Progress
Updated by Lucas Di Pentima over 3 years ago
Some comments below:
- File
apps/workbench/app/views/users/welcome.html.erb- There's funky indentation in the javascript code that makes it difficult to follow, could it be tidier?
- There's commented code at line 34
- The error message could be displayed in red font, or some other hint that makes it clear that's an error.
- Whenever the username or password field change, the error message could be cleared, for UI friendliness purposes (and consistency with wb2's login form).
- The
WelcomePageHTMLdefault config has some confusing wording, depending on the login method:- "The log in button below will show you a sign-in page...." - the sign-in page sometimes is the current one.
- "Arvados Workbench uses your name and email address only for id..." - the form doesn't ask for email address
Updated by Peter Amstutz over 3 years ago
Lucas Di Pentima wrote:
Some comments below:
- File
apps/workbench/app/views/users/welcome.html.erb
- There's funky indentation in the javascript code that makes it difficult to follow, could it be tidier?
Should be fixed.
- There's commented code at line 34
Fixed.
- The error message could be displayed in red font, or some other hint that makes it clear that's an error.
Done.
- Whenever the username or password field change, the error message could be cleared, for UI friendliness purposes (and consistency with wb2's login form).
Done.
- The
WelcomePageHTMLdefault config has some confusing wording, depending on the login method:
- "The log in button below will show you a sign-in page...." - the sign-in page sometimes is the current one.
- "Arvados Workbench uses your name and email address only for id..." - the form doesn't ask for email address
I removed the confusing wording, it should work for both login types.
I also fixed some integration tests.
17499-wb-login-form @ e8f266b10a8cd66209fd2ca6c64a100f86b8b887
https://ci.arvados.org/view/Developer/job/developer-run-tests/
Updated by Lucas Di Pentima over 3 years ago
This LGTM, there're some integration tests failing, but not sure if they're the usual flaky ones.
Updated by Peter Amstutz over 3 years ago
- Status changed from In Progress to Resolved
Updated by Peter Amstutz over 3 years ago
- Status changed from Resolved to Feedback
This has a couple of mistakes
Updated by Peter Amstutz over 3 years ago
Peter Amstutz wrote:
This has a couple of mistakes
Which were fixed in ecef6ad8ac0724b311c545412518b8fd1dc72b79
Updated by Peter Amstutz over 3 years ago
- Status changed from Feedback to Resolved