Arvados

17829-remove-omniauth @ 958a4eeb2011708d1c38f0d12f790a1462038e85

developer-run-tests: #2546

17829-remove-omniauth @ 5ade025ff305e91ec0238a0415b79f379e6d0157

Removed more SSO-related stuff

developer-run-tests: #2548

Reviewing 703bd34

• Some tests are failing: developer-run-tests: #2551
• File lib/config/config.default.yml - Line: 555 mentions SSO in a comment
• File lib/config/generated_config.go needs updating, it has SSO entries.
• File doc/api/tokens_sso.html.textile.liquid is being included on the documentation. It has some other token-related information that may need relocation.
• File sdk/python/tests/run_test_server.py has now old SSO config sections that make
• File services/api/test/test_helper.rb -- Line 28: mentions omniauth's initializer
• File build/rails-package-scripts/arvados-api-server.sh -- Line 17 also mentions omniauth initializer
• File services/api/app/views/static/intro.html.erb -- Line 21 mentions /auth/joshid. Also, that file mentions Curoverse in several places.
• File lib/controller/rpc/conn_test.go -- Line 55 has an assertion about the /auth/joshid callback.

17829-remove-omniauth @ 650df43af72632e22b7b99dfe7f55a1b5466e355

• Fix tests
• Fix a bunch of references to SSO or omniauth

developer-run-tests: #2552

17829-remove-omniauth @ 5fae618b1332cb654f0df026fb02f76b17f90225

developer-run-tests: #2553

17829-remove-omniauth @ b6d8769fd0b2c228861fff1343c51e3b376b58c9

developer-run-tests: #2554

Reviewing b6d8769

• Not wanting to scope creep but I've found more curoverse references at file services/api/app/controllers/arvados/v1/schema_controller.rb, not sure what's the function of those scopes URLs.
• Other than that, it LGTM

Lucas Di Pentima wrote:

Reviewing b6d8769

• Not wanting to scope creep but I've found more curoverse references at file services/api/app/controllers/arvados/v1/schema_controller.rb, not sure what's the function of those scopes URLs.

I think the idea is that we would limit API calls based on OAuth2 scopes associated with the token. But we never did that (our token scopes behave completely differently). I'm pretty sure it isn't used by anything but also mostly unrelated to this ticket so I am not going to mess with it.

• Other than that, it LGTM

Thanks, merged.