Actions
Bug #18003
closed
filter group validation incorrectly rejects 'contains' and 'exists'
Status:
Resolved
Priority:
Normal
Assigned To:
Category:
API
Target version:
Start date:
09/28/2021
Due date:
% Done:
100%
Estimated time:
(Total: 0.00 h)
Story points:
-
Release:
Release relationship:
Auto
Description
api/app/models/groups.rb
if ! ["=","<","<=",">",">=","!=","like","ilike","in","not in","is_a"].include?(filter[1].downcase)
errors.add :properties, "filter operator is not valid (must be =,<,<=,>,>=,!=,like,ilike,in,not in,is_a)"
return
end
This is missing the 'contains' and 'exists' operators.
Updated by Ward Vandewege over 3 years ago
This may be more complicated than just adding the operators; we've tried adding them and it produced confusing results.
Updated by Ward Vandewege over 3 years ago
Ready for review in 80889a19da3aacccc3ebcdfba73d037a54794b98 on branch 18003-support-exists-contains-in-filter-groups
Tests are running at developer-run-tests: #2714
Updated by Peter Amstutz over 3 years ago
Ward Vandewege wrote:
Ready for review in 80889a19da3aacccc3ebcdfba73d037a54794b98 on branch 18003-support-exists-contains-in-filter-groups
Tests are running at developer-run-tests: #2714
LGTM
Updated by Ward Vandewege over 3 years ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|9ce4b2c07e2b7809088e6333246501ad9418bbda.
Actions