Bug #18013
closed
[api] the rake tasks db:check_long_lived_tokens and db:fix_long_lived_tokens should take API.MaxTokenLifeTime into account
Added by Ward Vandewege over 3 years ago.
Updated about 3 years ago.
Estimated time:
(Total: 0.00 h)
Release relationship:
Auto
Description
These rake tasks only consider the Login.TokenLifeTime configuration value.
We want to use API.MaxTokenLifeTime instead. And if that is not set, use Login.TokenLifeTime, since the docs state that the former takes precedence.
- Status changed from New to In Progress
- Description updated (diff)
Just one comment:
- At line 55 there's a
next call that AFAICT makes the rake task return early but in that task, I think the idea is to report so maybe it would make more sense to just display the warning and continue with the iteration?
Apart from that, it LGTM.
Lucas Di Pentima wrote:
Just one comment:
- At line 55 there's a
next call that AFAICT makes the rake task return early but in that task, I think the idea is to report so maybe it would make more sense to just display the warning and continue with the iteration?
Apart from that, it LGTM.
Well, that `next` call is inside a loop so it just continues to the next iteration. It's true that the other `next` calls in the rake task make the task return early (they are the equivalent of a `return`). This is a rake task oddity, maybe I should just add a comment along those lines? If that makes sense I can merge this.
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by