Project

General

Profile

Actions
Copy link

Feature #18215

closed

Use 'select' on collection updates to avoid returning manifest_text

Added by Peter Amstutz about 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Lucas Di Pentima
Category:
-
Target version:
Arvados - 2021-11-24 sprint
Start date:
11/16/2021
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release:
Arvados 2.3.1
Release relationship:
Auto

Description

On the wb2 collection service, use select so that the update only returns the uuid field and not the manifest_text field in the response.

Subtasks 1 (0 open — 1 closed)

Arvados - Task #18355: Review 18215-collection-update-without-manifestResolvedStephen Smith11/16/2021

Actions

Related issues 1 (0 open — 1 closed)

Related to Arvados - Bug #18122: Support 'select' on 'get', 'update', and 'delete' calls to limit what fields are returned in update responseResolvedTom Clegg09/16/2021

Actions
Actions
Copy link
 #1

Updated by Peter Amstutz about 3 years ago

  • Target version set to 2021-10-27 sprint
Actions
Copy link
 #2

Updated by Peter Amstutz about 3 years ago

  • Category deleted (Workbench2)
  • Target version changed from 2021-10-27 sprint to 2021-11-10 sprint
Actions
Copy link
 #3

Updated by Peter Amstutz about 3 years ago

  • Target version changed from 2021-11-10 sprint to 2021-11-24 sprint
Actions
Copy link
 #4

Updated by Tom Clegg about 3 years ago

  • Related to Bug #18122: Support 'select' on 'get', 'update', and 'delete' calls to limit what fields are returned in update response added
Actions
Copy link
 #5

Updated by Peter Amstutz about 3 years ago

  • Description updated (diff)
Actions
Copy link
 #6

Updated by Lucas Di Pentima about 3 years ago

  • Assigned To set to Lucas Di Pentima
Actions
Copy link
 #7

Updated by Lucas Di Pentima about 3 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #8

Updated by Lucas Di Pentima about 3 years ago

Updates at commit:a969c0d3e - branch 18215-select-param-update-create
Test run: developer-run-tests: #2794

  • Makes controller to just respond with selected field on create & update calls.
Actions
Copy link
 #9

Updated by Tom Clegg about 3 years ago

18215-select-param-update-create LGTM - maybe worth adding Create and Update calls to (*RouterIntegrationSuite) TestSelectParam()?

Actions
Copy link
 #10

Updated by Lucas Di Pentima about 3 years ago

Updates at arvados-workbench2|e3655d66 - branch 18215-collection-update-without-manifest
Test run: developer-tests-workbench2: #510

  • Updates commonResourceService.update() so that it accepts an optional select param.
  • Updates collectionService.update() so that it automatically passes a select parameter with the list of updated fields, plus some other interesting ones like version & modified_at.
  • Modifies code handling the collection update() responses so that it updates the stored cache data instead of replacing it.
  • Adds test.
Actions
Copy link
 #11

Updated by Lucas Di Pentima about 3 years ago

Update at arvados-workbench2|cb5f37e7
Test run: developer-tests-workbench2: #511

Actions
Copy link
 #12

Updated by Stephen Smith about 3 years ago

This looks good to me

Actions
Copy link
 #13

Updated by Lucas Di Pentima about 3 years ago

  • Status changed from In Progress to Resolved
Actions
Copy link
 #14

Updated by Peter Amstutz about 3 years ago

  • Release set to 45
Actions
Copy link

Also available in: Atom PDF