Arvados

Changes at arvados-workbench2|281300c86c615248d124c8b5bb6b7a3461b63349 branch 18284-vm-listing
Tests: developer-tests-workbench2: #567

• Fixed display bugs to show correct vms and logins on user/admin pages
• Added create login dialog and remove login button on admin page
  • Logins are created with the same username as the user
  • Default group list is ['docker']
• Added list of groups on user vm page
• Added icon to vm admin breadcrumb

18284-vm-listing @ commit:281300c86c615248d124c8b5bb6b7a3461b63349

Admin VM panel¶

• Having default groups hardcoded into workbench seems like a bad idea. We could put something in the configuration but that's a bit of extra work, so let's just have it start empty.
  • The label could say something like "for example: docker, sudo"
• It's a little awkward and not obvious that you supposed to hit enter after typing the name of each group
• I crashed the app:
  1. Typed in "docker, sudo" for the groups
  2. Did not hit enter
  3. then hit "Add"
  4. crash screen with "TypeError: values.map is not a function"
• Similarly, if I type in "docker, sudo" and hit enter, I get a group called "docker, sudo" and not two groups
• It should split on at least commas and spaces, maybe also colons, semicolons, and reject most other punctuation (check what's legal for unix group names).
• As an admin, I can't easily see or edit the unix groups for a user. Could you make it so that clicking on a chip opens an "Update login permission" dialog so I can view or edit that specific login, with an "Update" button to save it?
  • This should be able to reuse existing "Add login permission" dialog -- for example https://github.com/arvados/sample-tracker/blob/c8baec286666266c080915ee247f9d84ab974e8f/patient.tsx#L90 for an example.

User VM panel¶

• Can we have a "copy to clipboard" button next to each entry in the "Command line" column?
• Can you tweak the styling so that "Log in as XYZ" looks like a button and not a hyperlink

Changes at arvados-workbench2|87ba49100005ac43690cd2f77b2f797154998d01
Tests developer-tests-workbench2: #581

• Added regex-based tokenization option for chips-input
• Added update login dialog
• Remove default groups and add hint text ("eg. docker, sudo")
• Fix chips error by removing extraneous onblur handler
• Add copy button to user vm ssh command
• Change webshell "log in as" link to button styling

Stephen Smith wrote:

Changes at arvados-workbench2|87ba49100005ac43690cd2f77b2f797154998d01
Tests developer-tests-workbench2: #581

• Added regex-based tokenization option for chips-input
• Added update login dialog
• Remove default groups and add hint text ("eg. docker, sudo")
• Fix chips error by removing extraneous onblur handler
• Add copy button to user vm ssh command
• Change webshell "log in as" link to button styling

This is really good! LGTM