Bug #18340
closed
Deleting 'role' and 'filter' groups should delete them immediately
100%
Description
originally brought up in #18339
side Q: how does should trash interact with 'role' groups? It appears a trashed 'role' group continues to be traversed for permissions until it is actually deleted from the system. Consider whether trashing a role group should either (a) not be allowed if there are outgoing permissions, (b) the operation of putting it in the trash should also delete all the outgoing permissions, or (c) the concept of trash doesn't apply to the role group, and it is always deleted immediately.
From discussion:
We probably want option (c), non-project groups should skip being trashed and be deleted immediately.
Updated by
Updated by Lucas Di Pentima about 3 years ago
- Assigned To set to Lucas Di Pentima
Updated by Lucas Di Pentima about 3 years ago
- Status changed from New to In Progress
Updated by Lucas Di Pentima about 3 years ago
Updates at 43d9cc591 - branch 18340-delete-role-filter-groups
Test run: developer-run-tests: #2802
- Only use
TrashableController.destroyonprojectgroups. - Adds test.
Updated by Ward Vandewege about 3 years ago
Lucas Di Pentima wrote:
Updates at 43d9cc591 - branch
18340-delete-role-filter-groups
Test run: developer-run-tests: #2802
- Only use
TrashableController.destroyonprojectgroups.- Adds test.
Just one question, why the removal of `protected` on line 354? Otherwise, LGTM, thanks!
Updated by Lucas Di Pentima about 3 years ago
Just for the record: the protected declaration was duplicated on that file.
Updated by Lucas Di Pentima about 3 years ago
- Status changed from In Progress to Resolved
Applied in changeset arvados-private:commit:arvados|2a13c742cdca6fbae46a9ce1c6ae044633d03ce3.