Bug #18787
closed
Collection's file browser re-rendering issues
Added by Lucas Di Pentima almost 3 years ago.
Updated about 2 years ago.
Estimated time:
(Total: 0.00 h)
Release relationship:
Auto
Description
As part of a general check of the app's UI refreshing issues in #18769 we tried removing the use of {force: true} on cypress tests' click() actions (see branch 18769-cypress-click-force-removal - arvados-workbench2|58820ac) and several tests started to fail with the following errors:
- CypressError: Timed out retrying after 4050ms: `cy.click()` failed because this element is detached from the DOM.
- CypressError: Timed out retrying after 4050ms: `cy.rightclick()` failed because this element is detached from the DOM.
This is probably a sign that there's some unnecessary re-rendering happening on the file browser, making the Cypress tests select an element that's immediately replaced by another similar one.
- Related to Bug #18769: Test & confirm no stale data or flickering during data table refreshes added
- Category deleted (
Workbench2)
- Assigned To set to Lucas Di Pentima
- Status changed from New to In Progress
- Target version changed from 2022-03-16 sprint to 2022-03-30 Sprint
- Target version changed from 2022-03-30 Sprint to 2022-04-13 Sprint
- Target version changed from 2022-04-13 Sprint to 2022-04-27 Sprint
- Target version changed from 2022-04-27 Sprint to 2022-05-25 sprint
I was using wb2 recently and there was a noticeable flicker when visiting the collection panel, the file browser appeared, blanked out, then appeared again.
Peter Amstutz wrote:
I was using wb2 recently and there was a noticeable flicker when visiting the collection panel, the file browser appeared, blanked out, then appeared again.
Hi Peter. I have a partial fix on the re-rendering related to the collection's panel loading process. The left & right browser sub-panels are handled differently, and I still get to see why the right side keeps re-rendering many times on load.
Was this collection being modified at the time you were seeing the flickering? If we also have flickering issues on collection updates, it's an excellent time to include them in this ticket.
- Target version changed from 2022-05-25 sprint to 2022-06-08 sprint
Updates at arvados-workbench2|f0f1a84 - branch 18787-file-browser-rerendering-fix
Test run: developer-tests-workbench2: #725 
This branch removes leftover code from the old file browser from several places and avoids forcing re-renderings because of duplicated action dispatches.
There're still improvement opportunities, especially on the browser's state handling code, which seems overly complicated, and I suspect cross-dependencies are forcing unneeded renderings.
The current improvements should fix the flaky tests that we were seeing. I believe they interact with collections so that they don't exercise the browser's "left side" listing that appears when accessing a subdirectory.
- Status changed from In Progress to Resolved
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by