Actions
Feature #18896
closed
[controller] should log the uuids of all tokens for each request
Start date:
03/26/2022
Due date:
% Done:
100%
Estimated time:
(Total: 0.00 h)
Story points:
-
Release:
Release relationship:
Auto
Updated by Ward Vandewege almost 3 years ago
- Status changed from New to In Progress
Updated by Ward Vandewege almost 3 years ago
- Subject changed from [controller] should log the uuid of the user and the token for each request. to [controller] should log the uuid of the user and the uuid of the token for each request.
- Status changed from In Progress to New
Updated by Ward Vandewege almost 3 years ago
- Related to Bug #18887: [federation] wb1 fiddlesticks in login federation added
Updated by Ward Vandewege almost 3 years ago
- Related to Story #17464: Logging and restricting downloads in keep-web and keepproxy added
Updated by Ward Vandewege almost 3 years ago
- Status changed from New to In Progress
- Assigned To set to Ward Vandewege
- Target version changed from 2022-04-13 Sprint to 2022-03-30 Sprint
- Release set to 46
8f0f3b495d0c715cc57d0d384bc5839acf9ece3f on branch 18896-controller-logs-tokenUUIDs adds token UUID logging.
Updated by Tom Clegg almost 3 years ago
This LGTM, thanks. Just a style nitpick, the "if ok"s should probably be "if !ok { return early }" instead of a pyramid. Could do this:
m, _ := ctx.Value(&mutexContextKey).(sync.Mutex)
c, _ := ctx.Value(&responseLogFieldsContextKey).(logrus.Fields)
if m == nil || c == nil {
return
}
// normal case
Updated by Ward Vandewege almost 3 years ago
Tom Clegg wrote:
This LGTM, thanks. Just a style nitpick, the "if ok"s should probably be "if !ok { return early }" instead of a pyramid. Could do this:
[...]
Thanks, done, and thanks for the test!
Updated by Ward Vandewege almost 3 years ago
- Subject changed from [controller] should log the uuid of the user and the uuid of the token for each request. to [controller] should log the uuids of all tokens for each request
Updated by Ward Vandewege almost 3 years ago
- Related to Feature #18944: [controller] should log the user uuid used for the request added
Updated by Ward Vandewege almost 3 years ago
- Status changed from In Progress to Resolved
Updated by Ward Vandewege almost 3 years ago
- Related to Feature #18897: [go services] should log the uuid of the token used for each request (and if available, the uuid of the associated user) added
Actions