Project

General

Profile

Actions
Copy link

Bug #18966

closed

Requesting a non-visible collection UUID shows a blank page

Added by Lucas Di Pentima over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Lucas Di Pentima
Category:
Workbench2
Target version:
Arvados - 2022-04-13 Sprint
Start date:
04/04/2022
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release:
Arvados 2.4.0
Release relationship:
Auto

Description

When a user attempts to view an existing collection that they don't have read access to, or a non-existing collection (but valid) UUID, the resulting UI is a blank page. (see attached screenshot)

From reading the browser's devtools networkl screen, it seems that collection is being request via a LIST call with all it's past versions, so a 404 response isn't available when the UUID cannot be accessed or doesn't exist.

Files

blank collection view.png (217 KB) blank collection view.png Lucas Di Pentima, 04/01/2022 05:12 PM

Subtasks 1 (0 open — 1 closed)

Task #18971: Review 18966-collection-not-found-uiResolvedStephen Smith04/04/2022

Actions

Related issues 1 (0 open — 1 closed)

Related to Arvados - Bug #18484: Direct links to Collections are retrieving the full manifest_text for no reason ResolvedLucas Di Pentima12/01/2021

Actions
Actions
Copy link
 #1

Updated by Lucas Di Pentima over 2 years ago

  • Status changed from New to In Progress
  • Assigned To set to Lucas Di Pentima
Actions
Copy link
 #2

Updated by Lucas Di Pentima over 2 years ago

  • Related to Bug #18484: Direct links to Collections are retrieving the full manifest_text for no reason added
Actions
Copy link
 #3

Updated by Lucas Di Pentima over 2 years ago

Updates at arvados-workbench2|c1c27e7f - branch 18966-collection-not-found-ui - developer-tests-workbench2: #640

  • Changes the collectionService.get() func to use a GET request instead of LIST. To avoid getting the manifest_text field, it passes a hardcoded list of default fields that excludes it.
  • Improves Cypress test related to the "not found" dialog, adding more cases, including collections.
  • Updates collectionService.get() unit tests to reflect the current behavior.
Actions
Copy link
 #4

Updated by Lucas Di Pentima over 2 years ago

Updates at arvados-workbench2|08c3068 - developer-tests-workbench2: #642

(previous test failure seems to be a caused by a new flaky test)

  • Changes Cypress config to avoid saving videos on successfull test cases. It saves ~15% of the current time it takes the whole run (around 5 minutes)
Actions
Copy link
 #5

Updated by Stephen Smith over 2 years ago

Only one minor thing - it looks like an it.only() snuck in from the main branch in the search spec L85, but otherwise everything passes and it LGTM!

Actions
Copy link
 #6

Updated by Lucas Di Pentima over 2 years ago

Updates at arvados-workbench2|41b06aa9 - developer-tests-workbench2: #643

  • Removes an it.only() call from the cypress/integration/search.spec.js test suite.
Actions
Copy link
 #7

Updated by Lucas Di Pentima over 2 years ago

  • Status changed from In Progress to Resolved
Actions
Copy link

Also available in: Atom PDF