Bug #19732: Error message incorrectly displayed when adding in key-value metadata in WB2 - Arvados

Actions

Copy link

Bug #19732

closed

Error message incorrectly displayed when adding in key-value metadata in WB2

Added by Sarah Zaranek about 2 years ago. Updated about 2 years ago.

Status:

Resolved

Priority:

Normal

Assigned To:

Lucas Di Pentima

Category:

Workbench2

Target version:

2022-12-21 Sprint

Start date:

12/07/2022

Due date:

% Done:

100%

Estimated time:

(Total: 0.00 h)

Story points:

0.5

Release:

Arvados 2.5.0

Release relationship:

Auto

Description

So, if I go to Edit Collection on a Collection Page and Put in a Pair and hit Add - the pair adds but I can given this error message "the field is required" in red under the field and it keeps the key. I am not sure why it adds the key- but since there isn't a value (cause WB2 removed it), it thinks there is a problem. This is super confusing because it looks like it had a problem adding your key-value pair

I took a snap shot and will add in comments below.

Files

Screenshot from 2022-11-09 15-51-52.png (33 KB) Screenshot from 2022-11-09 15-51-52.png

Sarah Zaranek, 11/09/2022 08:53 PM

Subtasks 1 (0 open — 1 closed)

Actions

Copy link

Updated by Sarah Zaranek about 2 years ago

File Screenshot from 2022-11-09 15-51-52.png Screenshot from 2022-11-09 15-51-52.png added
Category set to Workbench2

Here is a snapshot of me doing this on a collection in WB2.
https://workbench2.pirca.arvadosapi.com/collections/pirca-4zz18-6uvkbqb6rv2t6na --> this is the collection for completeness but I don't think this is a collection specific bug.

Actions

Copy link

Updated by Sarah Zaranek about 2 years ago

It does the same thing with the new collection page via the New Button - I am assuming they use the same code, but just in case they don't.

Actions

Copy link

Updated by Peter Amstutz about 2 years ago

Target version set to 2022-12-07 Sprint

Actions

Copy link

Updated by Lucas Di Pentima about 2 years ago

Assigned To set to Lucas Di Pentima

Actions

Copy link

Updated by Lucas Di Pentima about 2 years ago

Status changed from New to In Progress

Actions

Copy link

Updated by Lucas Di Pentima about 2 years ago

Target version changed from 2022-12-07 Sprint to 2022-12-21 Sprint

Actions

Copy link

Updated by Lucas Di Pentima about 2 years ago

Story points set to 0.5

Actions

Copy link

Updated by Lucas Di Pentima about 2 years ago

Updates at arvados-workbench2|c064afd - branch 19732-properties-error-fix
Test run: developer-tests-workbench2: #1016

Removes the require validation on property key & value fields.
Makes the Add button to enable itself when both fields have some value, in addition to the form's validations.
Updates test case.

Actions

Copy link