Arvados

Started 2800-python-global-state branch.

On 2800-pgs branch at c5f8a89

• Accept host, token, and insecure arguments in the api() call. If provided, use them rather than looking up environment variables.
  • This change obsoletes some awkward maneuvers with environment variables (some of this removed from tests/test_api.py).

• arvados.api() no longer returns a cached connection object with different credentials, endpoint, or "insecure" flag than the connection being requested. (Caching code used to assume only the requested version could change between calls to api().)
  • Example: this change makes it unnecessary for tests/test_api.py to clear the connection cache to prevent accidental future use of its fake credentials. Removed.
• If the caller says cache=False, don't use an existing connection (as before), but don't put the newly created connection object in the cache either.

• The credentials supplied to (or looked up by) arvados.api() are used for the life of the connection it returns. Previously, CredentialsFromEnv looked up the auth token in the global os.environ during each API method call.

• test_api.py uses a mock for API requests but still needs a discovery document. Now it uses run_test_server.py instead of relying on qr1hi.arvadosapi.com. This makes the test suite slower but more meaningful.

Just a few small comments on c5f8a89

• We can skip the step of hashing strings for a cache key. We can just create a tuple of all the values we care about, and use that directly as the lookup key. What do you think of that approach?
• Please keep imports sorted alphabetically.
• Please retain the comment in test_api.py about needing a real discovery document, to explain why we're running a test server.

Thanks.

Brett Smith wrote:

• We can skip the step of hashing strings for a cache key. We can just create a tuple of all the values we care about, and use that directly as the lookup key. What do you think of that approach?

Ah, yes, I was limiting myself to string keys for no reason. Now using tuple as dictionary key.

• Please keep imports sorted alphabetically.

Fixed (by not importing hashlib)

• Please retain the comment in test_api.py about needing a real discovery document, to explain why we're running a test server.

Indeed. Restored.

Thanks... now at 1e36870

Tom Clegg wrote:

Brett Smith wrote:

• Please keep imports sorted alphabetically.

Fixed (by not importing hashlib)

This is still an issue in test_api.py. Everything else looks good, so please go ahead and merge with that change. Thanks.

Fixed in 47dc22e. Thanks!