Tapestry

Annoying deprecation warning on should_allow_values_for and should_not_allow_values_for: we should switch to should allow_value(*values).for(attribute) but if there is more than one value we get a too many arguments error! This must be because of where shoulda is frozen in the Gemfile currently (see commit 89c0d5a02686bbd8b9746ce1849d880a7cd2b0a7). I can't get rid of the deprecation "properly" without separating these calls onto many lines (as I had to for validates_presence_of), and since I believe the problem will disappear after we upgrade Ruby and the shoulda gem, I'm going to leave these in and fix them when Ruby and shoulda gets upgraded. As long as there aren't too many exceptions like this, we should be able to keep things under control.

There are a series of tests related to User#in_screening_eligibility_group but it seems as if Tapestry grew out of using such groupings. There is no longer this method in the User model. However, there seem to be a residual controller and a lot of "waitlist" logic in the code base, and it's not yet clear to me whether all of this has been abandoned and should be removed entirely (which would help clean things up a bit, to be sure!), or whether this code should be maintained in the event that similar Enrollment Steps and conditions will be applicable again in the future.

In the meantime I am going to at least remove the in_screening_eligibility_group tests, since it can't make sense to test a method that was removed.