Actions
Bug #3136
closed[Crunch] Job state is stale in Workbench pipeline instance views, if the job's state changes after the pipeline instance stops.
Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Crunch
Target version:
Start date:
08/25/2014
Due date:
% Done:
100%
Estimated time:
(Total: 1.00 h)
Story points:
1.0
Description
Steps to reproduce:
- Run a pipeline
- Hit "Stop". This doesn't actually cancel the running jobs, see Bug #3165
- Go to the individual job page and cancel the job.
- Since the arv-run-pipeline-instance is no longer updating the copy of the job information in the pipeline instance record (why should it, it's stopped, right?) the pipeline will continue to show the job as running.
Quick resolution:
- In Workbench, look up each job by UUID instead of rendering the copy of the job record stored in the pipeline instance.
Updated by Brett Smith over 10 years ago
Reviewing the quick Workbench fix at aa0ae05
jobuuids = object.components.select { |cname, c| c[:job] and c[:job][:uuid] }
Since jobuuids gets passed into Job.where
, it looks to me like it should be an array, but select
will give you a subset of the hash. Should this be object.components.map { … }.compact
?
pj[:job] = job[c[:job][:uuid]]
Please check that we actually found a matching job before making this assignment. It's not guaranteed, and if we didn't, the method will crash trying to run nil[:success]
a little later.
Thanks.
Updated by Brett Smith over 10 years ago
- Status changed from In Progress to New
c1b0e1bd832d3c2c96e60334b96f3b6989ecd1b6 looks good. Thanks.
Updated by Anonymous over 10 years ago
- Status changed from New to Resolved
Applied in changeset arvados|commit:a17b176ea55dc3820ef1bde4b99cf33c628ffbbe.
Actions