Project

General

Profile

Actions

Story #3138

closed

[Workbench] UI improvements: Persistent top nav between pages

Added by Radhika Chippada over 10 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
-
Target version:
Start date:
07/22/2014
Due date:
% Done:

100%

Estimated time:
(Total: 4.00 h)
Story points:
2.0

Description

When navigating inside Workbench (at least sometimes, but ideally always), the top nav should stay stable and the page content area should indicate "loading". (Currently, after clicking a link, the user experiences a delay, then the entire page goes blank, then the next page appears.)

An easy strategy to solve [most of] this problem is to replace regular links with Javascript code to
  1. Display "loading" indication,
  2. Do an AJAX call to load just the "body-content DIV" part of the desired page,
  3. Replace the current body-content div with the new one.

The "wiselinks" gem can do most of this work for us, and lets us enable it selectively so we don't unwittingly break a bunch of stuff (which is what will happen if we turn on "turbolinks").

Caveats:
  • This tends to break the javascript-embedded-in-page pattern (especially (only?) with content_for :footer_js). Temporary solution: don't use wiselinks when linking to pages that use that pattern. Long term solution: Don't use the javascript-embedded-in-page pattern.
  • Also won't play well with "change breadcrumbs depending on which page you're looking at" system

Subtasks 2 (0 open2 closed)

Task #3310: Review branch: 3138-wiselinksResolvedRadhika Chippada07/22/2014

Actions
Task #3345: Remove all uses of :footer_js from workbenchResolvedRadhika Chippada07/22/2014

Actions
Actions

Also available in: Atom PDF