Feature #3454
closed
[API] Assign a system-default default docker image (instead of using the non-docker code path) if none is specified in runtime_constraints.
Added by Peter Amstutz over 10 years ago.
Updated over 9 years ago.
Assigned To:
Radhika Chippada
Estimated time:
(Total: 0.00 h)
- Subject changed from Reject jobs that are missing docker_image in runtime_constraints. to [API] Reject jobs that are missing docker_image in runtime_constraints.
- Category set to API
- Tracker changed from Bug to Feature
- Target version set to Arvados Future Sprints
- Subject changed from [API] Reject jobs that are missing docker_image in runtime_constraints. to [API] Assign a system-default default docker image (instead of using the non-docker code path) if none is specified in runtime_constraints.
- Story points set to 0.5
- Target version changed from Arvados Future Sprints to 2015-05-20 sprint
- Assigned To set to Radhika Chippada
- Status changed from New to In Progress
- If
Rails.configuration.default_docker_image_for_jobs
is false, and docker_image
is not set in the job, that should probably be a validation error instead of falling back to the old behavior (running in a non-Docker configuration)
- Instead of
runtime_constraints.is_a? Hash
suggest setting runtime_constraints ||= {}
I observed that making the job invalid when "no default config + runtime_constraints not including docker image" is a very drastic change. A large number of tests failed without the default config.
This made me wonder if we will have the very undesirable side effect of not being able to access jobs when the system does not have the default config.
I discussed this with Peter, and we decided to not do this as part of this update (the feature does not ask for it).
If we want this, we will address it in a different feature request.
- Status changed from In Progress to Resolved
Applied in changeset arvados|commit:1cea19230b490876f99194ea4d84970d6330ae12.
Also available in: Atom
PDF