Story #3527
closed
[Crunch] Remove check for "docker_image_hash" link when job supplies a keep locator for "docker_image" .
Added by Peter Amstutz over 10 years ago.
Updated over 10 years ago.
Estimated time:
(Total: 1.00 h)
- Status changed from New to In Progress
- Assigned To set to Brett Smith
- Subject changed from Remove check for "docker_image_hash" link when job supplies a keep locator for "docker_image" . to [Crunch] Remove check for "docker_image_hash" link when job supplies a keep locator for "docker_image" .
- Category set to Crunch
api/app/models/collection.rb requires dirname=='.' to recognize a docker image, but sdk/cli/bin/crunch-job doesn't require that. The sanity check should probably be the same in both places.
Other than that, this LGTM
- Category deleted (
Crunch)
Tom Clegg wrote:
api/app/models/collection.rb requires dirname=='.' to recognize a docker image, but sdk/cli/bin/crunch-job doesn't require that. The sanity check should probably be the same in both places.
As discussed in IRC, crunch-job was assuming that the Docker image would be stored in the '.' stream. I taught it to accept any stream from the Collection, and removed the dirname check from the API server. Please take another look.
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
Applied in changeset arvados|commit:eef298a7cf58771583b255fb0e3e1cfcbcdb6e48.
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by