Project

General

Profile

Actions
Copy link

Bug #5190

closed

[Workbench] Tell admins not to put hyphens in repository names

Added by Peter Amstutz almost 10 years ago. Updated almost 10 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
Workbench
Target version:
2015-03-11 sprint
Start date:
03/08/2015
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Description

Something removes dashes from repository names before creating the actual repository.

However, nobody told the API server that, which can result in a mismatch between the API server record (with dashes) and actual repository as managed by gitolite (without dashes).

The API server should validate the name to ensure that only valid repository names can be set.

Possibly related to #5192, as part of validation we may choose to disallow renaming one a name has been set.

Subtasks 1 (0 open — 1 closed)

Task #5424: Review branch: 5190-no-hyphens-in-repo-namesResolvedRadhika Chippada03/08/2015

Actions

Related issues 1 (0 open — 1 closed)

Related to Arvados - Bug #5192: [API] Disallow changing the name of a repository record (by non-admin users)ResolvedRadhika Chippada

Actions
Actions
Copy link
 #1

Updated by Peter Amstutz almost 10 years ago

  • Subject changed from [API] Dashes are removed from repository names to [API] Repository names not validated properly
  • Description updated (diff)
Actions
Copy link
 #2

Updated by Peter Amstutz almost 10 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Tom Clegg almost 10 years ago

  • Subject changed from [API] Repository names not validated properly to [API] Tell admins not to put hyphens in repository names
  • Story points set to 0.5
Actions
Copy link
 #4

Updated by Tom Clegg almost 10 years ago

  • Story points deleted (0.5)
Actions
Copy link
 #5

Updated by Tom Clegg almost 10 years ago

  • Target version changed from Bug Triage to 2015-03-11 sprint
Actions
Copy link
 #6

Updated by Radhika Chippada almost 10 years ago

  • Category set to Workbench
  • Status changed from New to In Progress
  • Assigned To set to Radhika Chippada
Actions
Copy link
 #7

Updated by Peter Amstutz almost 10 years ago

The description says

"The API server should validate the name to ensure that only valid repository names can be set."

However the branch doesn't do that.

Actions
Copy link
 #8

Updated by Peter Amstutz almost 10 years ago

Alternately (if the story was de facto updated without updating the story description) the text at least needs to be stronger: "Warning: do not use hyphens in the repository name as they will be stripped".

Actions
Copy link
 #9

Updated by Radhika Chippada almost 10 years ago

  • Subject changed from [API] Tell admins not to put hyphens in repository names to [Workbench] Tell admins not to put hyphens in repository names

Yes, we decided to just inform the admin users to not use hyphens and not really address the actual gitolite issue. Thanks.

Actions
Copy link
 #10

Updated by Radhika Chippada almost 10 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:cab38660eec30ff5d4e023f5d607d783ffd91785.

Actions
Copy link
 #11

Updated by Ward Vandewege almost 10 years ago

  • Story points set to 0.5
Actions
Copy link

Also available in: Atom PDF