Arvados

reviewing 6090-docker-use-local-sso commit ae3bb0033a24a38489c49ffc26e5a5e8fd93c160

docker/arvdock¶

• line 13: hardcoded ARVADOS_DOMAIN=dev.arvados should a parameter
• line 224: why commenting out #start_vm=true ?

docker/config.yml.example¶

• just a curiosity.. is this used as template somewhere in curoverse? or is just for the (external) user to have an example?

docker/workbench/apache2_vhost.in¶

• line 26: why is qr1hi hardcoded there? even is a comment couldn't be @ARVADOS_DOMAIN@

So I cant really test this in my machine... I have space restrictions and SSD drive is incredible slow. Options here?

Nico Cesar wrote:

reviewing 6090-docker-use-local-sso commit ae3bb0033a24a38489c49ffc26e5a5e8fd93c160

docker/arvdock¶

• line 13: hardcoded ARVADOS_DOMAIN=dev.arvados should a parameter

Fixed

• line 224: why commenting out #start_vm=true ?

Right now it doesn't really work, so it seems better to disable it entirely.

docker/config.yml.example¶

• just a curiosity.. is this used as template somewhere in curoverse? or is just for the (external) user to have an example?

It's used by docker/build_tools/build.sh

docker/workbench/apache2_vhost.in¶

• line 26: why is qr1hi hardcoded there? even is a comment couldn't be @ARVADOS_DOMAIN@

Removed those comments since they are useless.

checked a7d558d6c2db242a6555c7f397cb4d91618aa13c

looks good to me