Arvados

I don't know what this block starting at L316 is doing, and it won't work because (a) the OutputPath inside the container is different from the HostOutputDir and (b) the HostOutputDir may not exist yet if it hasn't processed all the mounts yet. I think you can just remove the code entirely.

} else if mnt.Kind == "file" {
...
}

In AttachStreams(), runner.ContainerRecord.Mounts is a map, so you don't need to iterate over it. You can just say

if mnt, ok := runner.ContainerRecord.Mounts["stdout"]; ok {
...
}

L429: Should be path.Join(runner.HostOutputDir, stdoutSubdirs)

L434: It's not necessary to call os.Stat() after os.MkdirAll() if you're going to ignore the return value.

L437: also should be path.Join(runner.HostOutputDir, stdoutPath)

73550248

I don't know what this block starting at L316 is doing

Removed this and updated the tests

In AttachStreams(), runner.ContainerRecord.Mounts is a map, so you don't need to iterate over it. You can just say

Right, updated it

L429: Should be path.Join(runner.HostOutputDir, stdoutSubdirs)
L437: also should be path.Join(runner.HostOutputDir, stdoutPath)

Updated

L434: It's not necessary to call os.Stat() after os.MkdirAll() if you're going to ignore the return value.

Yes, I had this during my test / debug cycle and failed to see it afterwards. Removed it.

Thanks.