Project

General

Profile

Actions
Copy link

Feature #8754

open

[Tests] Add code-checking tools to CI test pipeline

Added by Tom Clegg almost 9 years ago. Updated almost 5 years ago.

Status:
New
Priority:
Normal
Assigned To:
-
Category:
Tests
Target version:
-
Start date:
03/15/2016
Due date:
% Done:

0%

Estimated time:
Story points:
-

Description

run-tests.sh should fail on any new errors/warnings caught by lint tools.

Some tools rate our tree at 100% (e.g., gofmt). For these tools we can simply fail if they give us less than 100%.

In other cases we have a big backlog of errors/warnings to clean up. Rather than try to fix them all at once before adding checks, it would be good to find a way to at least prevent (most) changes that make that backlog worse, then chip away at it.

Specific tools

Python: Go:
  • go vet
  • golint
  • gofmt
  • gometalinter (includes all of the above)
Ruby:
  • Ruby 2.2 produces a lot of warnings when running tests. When we get there, we should aim for zero warnings. But for now we can't even pass tests in 2.2, so this doesn't help much.
  • ruby-lint
  • RuboCop
Actions
Copy link

Also available in: Atom PDF