Arvados » Arvados Workbench 2

Fix at arvados-workbench2|0429d378 - branch 17319-service-layer-uuid-validation
Test run: developer-tests-workbench2: #293

• Validates that uuid is not an empty string on CommonService's get(), update() and delete() calls.
• Adds unit tests.

src\services\common-service\common-service.test.ts

const axiosInstance = axios.create();
    // const axiosMock = new MockAdapter(axiosInstance);
    const commonService = new CommonService(axiosInstance, "resource", actions);

please use mock and wrap this code in the beforeEach

Updates at arvados-workbench2|6a66e260

• Moves mock's init to beforeEach()

        commonService = new CommonService<any>(axiosInstance, "resource", actions);
        axiosInstance = axios.create();

should be

        axiosInstance = axios.create();
        commonService = new CommonService<any>(axiosInstance, "resource", actions);

as on a first call axiosInstance is null, on the other hand are you sure that you want to use axios without mocking within the test file?

Updates at arvados-workbench2|0c04dddf

I've cleaned up the test code a little bit, the axios instance is created just to satisfy the CommonService constructor, it's not being used on the test cases.
AFAICT, the axios mock would allow me to re-record test responses but in these test cases I'm not testing that, I'm just confirming that exceptions are being thrown when uuid=="" on some service calls.

Could you explain a little bit about your concerns? I'm not too experienced on TypeScript/Javascript testing. Thanks!

Update at arvados-workbench2|eb40293b

Don't use a real AxiosInstance when not needed, to avoid potential issue with future test authors.