Actions
Bug #17568
closedGet API token dialog shows incorrect token expiration on federated tokens
Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
04/29/2021
Due date:
% Done:
100%
Estimated time:
(Total: 0.00 h)
Story points:
-
Release:
Release relationship:
Auto
Description
Federated tokens make WB2 to show their internal refresh token timeout setting instead of the real token expiration.
Updated by Lucas Di Pentima over 3 years ago
- Status changed from New to In Progress
Updated by Lucas Di Pentima over 3 years ago
Updates at arvados-workbench2|7d40a4a - branch 17568-api-token-dialog-expiration-fix
Test run: developer-tests-workbench2: #397
- Makes wb2 ask for federated token to the correct cluster.
- Adds unit test -- lots of mocking to simulate a federation, I hope the approach is correct.
Updated by Lucas Di Pentima over 3 years ago
- Target version changed from 2021-04-28 bughunt sprint to 2021-05-12 sprint
Updated by Peter Amstutz over 3 years ago
17568-api-token-dialog-expiration-fix @ 7d40a4a432ce8dfea8e49f3d330220aea6957790
This LGTM, just a couple of comments:
- Does typescript have
finally
?- await dispatch<any>(saveApiToken(token)); // .then(() => { - await dispatch(progressIndicatorActions.STOP_WORKING(WORKBENCH_LOADING_SCREEN)); - } catch (e) { - dispatch(progressIndicatorActions.STOP_WORKING(WORKBENCH_LOADING_SCREEN)); - } + await dispatch<any>(saveApiToken(token)); + } catch (e) {} + dispatch(progressIndicatorActions.STOP_WORKING(WORKBENCH_LOADING_SCREEN));
- It would be nice if the expiration time was also expressed as an approximate duration: "will expire in X days|hours|minutes" in addition to giving the time and date. This is not a blocker, just an observation.
Updated by Lucas Di Pentima over 3 years ago
Peter Amstutz wrote:
- Does typescript have
finally
?
Whoops, you're right, fixed!
- It would be nice if the expiration time was also expressed as an approximate duration: "will expire in X days|hours|minutes" in addition to giving the time and date. This is not a blocker, just an observation.
Found a nice library (Moment.js) that does this and other time related tasks really nicely.
Updates at arvados-workbench2|ec121e0
Test run: developer-tests-workbench2: #400
Updated by Anonymous over 3 years ago
- Status changed from In Progress to Resolved
Applied in changeset arvados:arvados-workbench2|fcfb353fa27b5399e44f32944e0d53015b89a3b8.
Actions