Arvados » Arvados Workbench 2

Updates at arvados-workbench2|7d40a4a - branch 17568-api-token-dialog-expiration-fix
Test run: developer-tests-workbench2: #397

• Makes wb2 ask for federated token to the correct cluster.
• Adds unit test -- lots of mocking to simulate a federation, I hope the approach is correct.

17568-api-token-dialog-expiration-fix @ 7d40a4a432ce8dfea8e49f3d330220aea6957790

This LGTM, just a couple of comments:

• Does typescript have finally ?
  

  -            await dispatch<any>(saveApiToken(token)); // .then(() => {
  -            await dispatch(progressIndicatorActions.STOP_WORKING(WORKBENCH_LOADING_SCREEN));
  -        } catch (e) {
  -            dispatch(progressIndicatorActions.STOP_WORKING(WORKBENCH_LOADING_SCREEN));
  -        }
  +            await dispatch<any>(saveApiToken(token));
  +        } catch (e) {}
  +        dispatch(progressIndicatorActions.STOP_WORKING(WORKBENCH_LOADING_SCREEN));
  

• It would be nice if the expiration time was also expressed as an approximate duration: "will expire in X days|hours|minutes" in addition to giving the time and date. This is not a blocker, just an observation.

Peter Amstutz wrote:

• Does typescript have finally ?

Whoops, you're right, fixed!

• It would be nice if the expiration time was also expressed as an approximate duration: "will expire in X days|hours|minutes" in addition to giving the time and date. This is not a blocker, just an observation.

Found a nice library (Moment.js) that does this and other time related tasks really nicely.

Updates at arvados-workbench2|ec121e0
Test run: developer-tests-workbench2: #400