Tapestry

• failure due to successful download with right size but wrong md5sum: https://crvr.se/su92l-8i9sb-ful8qhzowkshfoq
• success: https://crvr.se/su92l-8i9sb-aizw0cupzxafowf

Reviewing db7bd2a. This is good to merge, these are all just "idiomatic Python" nits that you can take or leave as you like.

cStringIO provides the same API as StringIO with better performance. You can switch to it with a one-line change by changing your import to import cStringIO as StringIO.

It seems a little odd that you open the URL, then check its scheme. Maybe move that up? You might also consider saving the result of urlparse.urlparse() and reusing it, but that's really small potatoes.

Your download loop can be written a little DRYer as:

   with open(outpath, 'w') as outfile:
        for chunk in iter(lambda: httpresp.read(BUFFER_SIZE), ''):
            outfile.write(chunk)
            got_md5.update(chunk)
        got_size = outfile.tell()

Thanks.

All of that sounds better, thanks. I was torn between the two uglies -- while-True-if-cond-break and duplicating the read() -- the iter solution is just what I was wishing for.

• success: https://crvr.se/su92l-8i9sb-gll3t23dfh3bc8v
• md5 fail: https://crvr.se/su92l-8i9sb-ligg07lys87apqb

Tom Clegg wrote:

Now at aee617c with new test jobs:

That looks great, thanks.