Arvados

Not to dive into implementation details, but introducing a general purpose metrics package may provide benefits going forward.

I've used the Dropwizard metrics in the past and like them. A Go port of that package can be found here: https://github.com/armon/go-metrics

There's also: https://github.com/rcrowley/go-metrics which is described in this blog post: http://blog.dekstroza.io/monitoring-software-written-in-golang/

S3 Error codes are listed here: http://docs.aws.amazon.com/AmazonS3/latest/API/ErrorResponses.html#ErrorCodeList

• I am unable to run tests. Seeing this error when I invoke run-tests with install: (with go version go1.7 linux/amd64)

  ********** Running services/keepstore install **********

package context: unrecognized import path "context" (import path does not begin with hostname)

    ********** !!!!!! services/keepstore install FAILED !!!!!! **********

• In s3_volume.go -> IndexTo method, why invoke stats.tick twice in a row at lines 459 and 460?

Radhika Chippada wrote:

• I am unable to run tests. Seeing this error when I invoke run-tests with install: (with go version go1.7 linux/amd64)

package context: unrecognized import path "context" (import path does not begin with hostname)

Hm, not sure what to make of this. https://blog.golang.org/go1.7 says context was added to stdlib in go1.7. Does it help to reinstall (1.7.3 is current)? Maybe make sure you don't have a GOROOT pointing to an older Go installation?

• In s3_volume.go -> IndexTo method, why invoke stats.tick twice in a row at lines 459 and 460?

One for dataL.First() and one for recentL.First(), both on the following line...

Tom said:

Maybe make sure you don't have a GOROOT pointing to an older Go installation

Yes, this was the cause. Tests are passing now.

LGTM

10484-count-clients @ f3c31e7c71f076f5feafbb3f14e210f4d0de9012

Branch 10484-count-clients LGTM