Actions
Story #11710
closed
[Workbench][Performance] container / container_request show page taking too long to load
Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
-
Target version:
Start date:
05/18/2017
Due date:
% Done:
100%
Estimated time:
(Total: 0.00 h)
Story points:
-
Description
Loading of the pages /containers/qr1hi-dz642-uypqs2exiy7so7l and /container_requests/qr1hi-xvhdp-6490dha4xorrfwz takes more than 60s each.
A couple observations:
- Each container_uuid of each child is being fetched in a separate request
- cputime computation is taking a long time as all descendants are being fetched one at a time
Updated by Radhika Chippada over 7 years ago
- Subject changed from [Workbench][Performance] container / container_request show page takes too long to load due to fetching of each associated container in a separate request to [Workbench][Performance] container / container_request show page taking too long to load
- Description updated (diff)
Updated by Radhika Chippada over 7 years ago
- Status changed from New to In Progress
- Assigned To set to Radhika Chippada
- Target version set to 2017-05-24 sprint
Updated by Lucas Di Pentima over 7 years ago
Just a couple of small comments:
- File
apps/workbench/app/models/container_work_unit.rb- Could lines 24 & 26 be unified by using an ‘
||’ operator?
**Line 32: Typo detected oncr.request_container_uuid(also make workbench_units tests fail)
- Could lines 24 & 26 be unified by using an ‘
Apart from those, lgtm.
Updated by Radhika Chippada over 7 years ago
@ d7e956d1ed2ffeb5b585896e6568481d474bb095
Could lines 24 & 26 be unified by using an ‘||’ operator?
Yes, I cleaned up this and some more
Line 32: Typo detected on cr.request_container_uuid (also make workbench_units tests fail)
Gee thanks for catching this. I corrected this and started tests @ https://ci.curoverse.com/job/developer-run-tests/292/
Updated by Radhika Chippada over 7 years ago
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
Applied in changeset arvados|commit:49a9c33ea6119c42ad3d2d585ed7b2f9e4339132.
Actions