Actions
Story #11870
closed[Workbench] We have two pages /repositories, and /users/<uuid>/repositories. Move the functionality from /users/<uuid>/repositories page into /repositories and remove it.
Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
-
Target version:
Start date:
06/30/2017
Due date:
% Done:
100%
Estimated time:
(Total: 0.00 h)
Story points:
-
Updated by Radhika Chippada over 7 years ago
In addition, add paging or infinite scrolling to the page.
Updated by Radhika Chippada over 7 years ago
- Assigned To set to Radhika Chippada
Updated by Radhika Chippada over 7 years ago
- Status changed from New to In Progress
Updated by Radhika Chippada over 7 years ago
Branch 11870-repositories-index
- /repositories page is improved to show URL column and display order (owned first and then the rest, sorted by name) as does the user menu repositories page. Also, added infinite scrolling.
- User menu repositories link now links to /repositories. Removed / moved the associated code
- Updated tests accordingly. List of impacted tests: https://ci.curoverse.com/job/developer-run-tests/368/
Updated by Lucas Di Pentima over 7 years ago
Reviewing d898b4cb9
- File
apps/workbench/app/controllers/repositories_controller.rb
- Lines 37, 38: Those conditionals assignments could be simplified by using
andand
.
- Lines 37, 38: Those conditionals assignments could be simplified by using
- File
apps/workbench/app/views/repositories/_show_help.html.erb
- Line 3: Shouldn’t the
limit(1)
be after thefilter()
? - Lines 3 & 4 could be simplified by using
||
- Line 3: Shouldn’t the
- Jenkins tests have failed
Updated by Radhika Chippada over 7 years ago
- Updated repositories_controller.rb and _show_help.html.erb accordingly @ 30186c3f928d280e4af97a4989d7a82dfe68d592
- The test failures appear to be due to jenkins env being unstable. All but one test for projects_test passed in this run: https://ci.curoverse.com/job/developer-run-tests/372/ (which passed in the earlier run + locally). Rerunning @ https://ci.curoverse.com/job/developer-run-tests/374/ but I wouldn't worry about it.
Thanks.
Updated by Radhika Chippada over 7 years ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|commit:019c7c67a37cd2a6e43ceed73771c1cd87c5f615.
Actions