Actions
Bug #14595
closed
[API] logs.event_at has wrong timestamp
Start date:
12/13/2018
Due date:
% Done:
100%
Estimated time:
(Total: 0.00 h)
Story points:
-
Release:
Release relationship:
Auto
Description
Some updates generate rows in the logs table with event_at set to the time of a previous update, not the one being logged:
logs.event_atis populated fromobject_being_updated.modified_at(notdb_current_timelike you might guess)object_being_updated.modified_atis not updated when the updates are saved inside aleave_modified_user_aloneblock
- Use db_current_time for the log entry
- Revert the part of #13168 that avoids updating modified_at. (The original premise of #13168 was to stop changing
modified_by_user_uuid. I don't see anything in the commit messages or on the ticket explaining why we stopped changingmodified_atas well -- perhaps we didn't need to?)
Updated by Tom Clegg about 6 years ago
- Related to Bug #13168: [API] state/priority-change triggers should not change container request modified_by_user_uuid to root added
Updated by Tom Morris about 6 years ago
- Target version changed from To Be Groomed to 2018-12-21 Sprint
Updated by Peter Amstutz about 6 years ago
On further research, this is a regression introduced in 647511030800d228feb6955dfab9cb0a26cbfcfb as part of collection versions.
The leave_modified_by_user_alone should be restored to its previous behavior and a new leave_modified_at_alone should be added to accommodate the collection versions use case.
Updated by Peter Amstutz about 6 years ago
14595-leave-modified-at @ 2aa58f31ac8fc696361214a05ab9ba75a5140b08
https://ci.curoverse.com/view/Developer/job/developer-run-tests/1010/
- Add leave_modified_at_alone
- leave_modified_by_user_alone does not affect modified_at
Updated by Lucas Di Pentima about 6 years ago
Just one small comment: On services/api/lib/arvados_model_updates.rb:L23 the comment refers to "modified_at_uuid" field. The rest LGTM.
Actions