Project

General

Profile

Actions
Copy link

Bug #16101

closed

https://ce8i5.arvadosapi.com/users/sign_out path not found

Added by Peter Amstutz almost 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Tom Clegg
Category:
Login
Target version:
2020-02-26 Sprint
Start date:
02/18/2020
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release:
Arvados 2.0.1
Release relationship:
Auto

Description

When using Controller's native Google login, logging out results in an error.

Subtasks 1 (0 open — 1 closed)

Task #16149: Review 16101-logoutResolvedPeter Amstutz02/18/2020

Actions
Actions
Copy link
 #1

Updated by Peter Amstutz almost 5 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Peter Amstutz almost 5 years ago

  • Category set to Login
Actions
Copy link
 #3

Updated by Peter Amstutz almost 5 years ago

  • Target version changed from 2020-02-12 Sprint to 2020-02-26 Sprint
Actions
Copy link
 #4

Updated by Tom Clegg almost 5 years ago

Controller needs a Logout() method that bypasses railsProxy when Login.GoogleClientID is configured, similar to Login() in source:lib/controller/localdb/conn.go. The native implementation doesn't set cookies so I think this is a no-op, just redirecting to the return_to param value (or if none provided, workbench2?).

Actions
Copy link
 #5

Updated by Peter Amstutz almost 5 years ago

  • Target version changed from 2020-02-26 Sprint to 2020-03-11 Sprint
Actions
Copy link
 #6

Updated by Peter Amstutz almost 5 years ago

  • Target version changed from 2020-03-11 Sprint to 2020-02-26 Sprint
Actions
Copy link
 #7

Updated by Peter Amstutz almost 5 years ago

  • Assigned To set to Tom Clegg
Actions
Copy link
 #8

Updated by Tom Clegg almost 5 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #10

Updated by Peter Amstutz almost 5 years ago

Tom Clegg wrote:

16101-logout @ e459f4e2d40762f67ffedafbe988c8da6f4f04d4 -- developer-run-tests: #1736

It looks like if return_to is unspecified you'll get a blank (invalid) redirect. The API server sends you to the API server root (return_to = params[:return_to] || root_url) but sending you to Workbench by default would probably be better.

Actions
Copy link
 #12

Updated by Peter Amstutz almost 5 years ago

Tom Clegg wrote:

16101-logout @ e15c73164eaedc121420b328a7b26da3c35bc145 -- developer-run-tests: #1738

This LGTM

Actions
Copy link
 #13

Updated by Anonymous almost 5 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #14

Updated by Peter Amstutz almost 5 years ago

  • Release set to 29
Actions
Copy link

Also available in: Atom PDF