Actions
Feature #18001
closed
[api] add Users/UserNotifierEmailBcc config option
Start date:
08/13/2021
Due date:
% Done:
100%
Estimated time:
(Total: 0.00 h)
Story points:
-
Release:
Release relationship:
Auto
Updated by Ward Vandewege over 3 years ago
- Status changed from New to In Progress
Updated by Ward Vandewege over 3 years ago
- Target version set to 2021-08-18 sprint
Updated by Ward Vandewege over 3 years ago
Ready for review at 89f8175850a9279036053b2a6785980a479e08d8 on branch 18001-add-UserNotifierEmailBcc
Tests ran at developer-run-tests: #2631 . The wb functionals had an unrelated failure, it passed when re-run at developer-run-tests-apps-workbench-functionals: #2673
.
Updated by Peter Amstutz over 3 years ago
arvcfg.declare_config "Users.UserNotifierEmailBcc", Hash, ->(cfg, k, v) { arrayToHash cfg, "Users.UserNotifierEmailBcc", v }
The ->(cfg, k, v) {...} part is incorrect, that's only for keys that need to be migrated from legacy application.yml. It should be just:
arvcfg.declare_config "Users.UserNotifierEmailBcc", Hash
The rest LGTM
Updated by Ward Vandewege over 3 years ago
Peter Amstutz wrote:
[...]
The
->(cfg, k, v) {...}part is incorrect, that's only for keys that need to be migrated from legacy application.yml. It should be just:[...]
The rest LGTM
Great thanks, merged with that change.
Updated by Ward Vandewege over 3 years ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|e1d178affae6eb4c8a09deafa0b980b3f440b278.
Actions