Arvados

18316-fuse-read-only @ d3ffe252f9d7cbbad9a7bf61ccf5d26129720f43

developer-run-tests: #2795

This propagates the enable_write flag to the FUSE directory/file python objects to ensure that when in read-only mode, it won't try to save the collection.

Does not fix the related bug that in read-write mode, it still doesn't track if the user has write permission on a collection or not, or if you tried to change the collection or not. So you'll still get error-on-close if you access a file in a collection that was loaded by uuid (via MagicDirectory or ProjectDirectory). This requires a bit more thought on how best to implement properly.

Although the updates and test look good, I'm wondering why the original report said that this didn't happen on versions previous to 2.3.0

I've tried to do a manual test against a local arvbox instance, and I'm getting I/O Errors when doing a simple cat <file>. Am I doing something wrong here?

(venv-arvados) lucas@buster:~$ arv-mount --version
/home/lucas/venv-arvados/bin/arv-mount 2.4.0.dev20211112222152
(venv-arvados) lucas@buster:~$ arv-mount ./tmp
(venv-arvados) lucas@buster:~$ cd ./tmp/by_id/x240b-4zz18-e1s0llgw4y50icd
(venv-arvados) lucas@buster:~/tmp/by_id/x240b-4zz18-e1s0llgw4y50icd$ cat test.js
cat: test.js: Input/output error

Same thing with --debug:

(venv-arvados) lucas@buster:~$ arv-mount --debug ./tmp
2021-11-15 13:27:53 arvados.arv-mount[24252] DEBUG: arv-mount debugging enabled
2021-11-15 13:27:53 arvados.arv-mount[24252] INFO: /home/lucas/venv-arvados/bin/arv-mount 2.4.0.dev20211112222152 started
2021-11-15 13:27:53 arvados.arv-mount[24252] INFO: enable write is False
2021-11-15 13:27:54 arvados.arvados_fuse[24252] DEBUG: InodeCache touched inode 5 (size 0) (uuid x240b-tpzed-k11iuqilds4s827) total now 0 (1 entries)
FUSE library version: 2.9.9
(venv-arvados) lucas@buster:~$ cd ./tmp/by_id/x240b-4zz18-e1s0llgw4y50icd
(venv-arvados) lucas@buster:~/tmp/by_id/x240b-4zz18-e1s0llgw4y50icd$ cat test.js
cat: test.js: Input/output error

Let me re-do my manual test with arvbox in dev mode instead of publicdev because part of the log says:

2021-11-15 13:40:10 arvados.keep[14412] DEBUG: Request fail: GET http://localhost:25107/136b64e537cfd8920f03646ab852fb61+46+A1975c2037e57581f288f8820b26e005b86e5ac92@61a5022b => <class 'arvados.errors.HttpError'>: (0, "(7, 'Failed to connect to localhost port 25107: Connection refused')")
2021-11-15 13:40:10 arvados.arvados_fuse[14412] ERROR: Unhandled exception during FUSE operation
Traceback (most recent call last):
  File "/home/lucas/venv-arvados/lib/python3.7/site-packages/arvados_fuse-2.4.0.dev20211112222152-py3.7.egg/arvados_fuse/__init__.py", line 327, in catch_exceptions_wrapper
    return orig_func(self, *args, **kwargs)
  File "/home/lucas/venv-arvados/lib/python3.7/site-packages/arvados_fuse-2.4.0.dev20211112222152-py3.7.egg/arvados_fuse/__init__.py", line 655, in read
    r = handle.obj.readfrom(off, size, self.num_retries)
  File "/home/lucas/venv-arvados/lib/python3.7/site-packages/arvados_fuse-2.4.0.dev20211112222152-py3.7.egg/arvados_fuse/fusefile.py", line 66, in readfrom
    return self.arvfile.readfrom(off, size, num_retries, exact=True)
  File "/home/lucas/venv-arvados/lib/python3.7/site-packages/arvados/arvfile.py", line 1106, in readfrom
    block = self.parent._my_block_manager().get_block_contents(lr.locator, num_retries=num_retries, cache_only=(bool(data) and not exact))
  File "/home/lucas/venv-arvados/lib/python3.7/site-packages/arvados/arvfile.py", line 784, in get_block_contents
    return self._keep.get(locator, num_retries=num_retries)
  File "/home/lucas/venv-arvados/lib/python3.7/site-packages/arvados/retry.py", line 177, in num_retries_setter
    return orig_func(self, *args, **kwargs)
  File "/home/lucas/venv-arvados/lib/python3.7/site-packages/arvados/keep.py", line 1056, in get
    return self._get_or_head(loc_s, method="GET", **kwargs)
  File "/home/lucas/venv-arvados/lib/python3.7/site-packages/arvados/keep.py", line 1182, in _get_or_head
    "[{}] failed to read {} after {}".format(request_id, loc_s, loop.attempts_str()), service_errors, label="service")
arvados.errors.KeepReadError: [req-qgowoe2t8nm779xdla27] failed to read 136b64e537cfd8920f03646ab852fb61+46+A1975c2037e57581f288f8820b26e005b86e5ac92@61a5022b after 5 attempts: service http://localhost:25108/ responded with 0 (7, 'Failed
to connect to localhost port 25108: Connection refused'); service http://localhost:25107/ responded with 0 (7, 'Failed to connect to localhost port 25107: Connection refused')

Maybe I'm having a keepproxy issue.

It worked on dev mode, LGTM.