Bug #19683
closedarvbox broken by ruby dev dependency
100%
Description
Arvbox demo currently doesn't build because the login-sync step needs a dev version of the arvados gem but the arvbox scripts haven't been updated to install it before installing other ruby stuff.
Updated by Peter Amstutz about 2 years ago
- Status changed from New to In Progress
Updated by Lucas Di Pentima about 2 years ago
Updates at 3070a6d - branch 19683-arvbox-rubysdk-fix
Test run: developer-run-tests: #3349
- Conditionally builds && install the
arvados
gem dev version so thatlogin-sync
can be installed.
Updated by Peter Amstutz about 2 years ago
Lucas Di Pentima wrote in #note-4:
Updates at 3070a6d - branch
19683-arvbox-rubysdk-fix
Test run: developer-run-tests: #3349
- Conditionally builds && install the
arvados
gem dev version so thatlogin-sync
can be installed.
Shell script style comments:
instead of test "$(flock $GEMLOCK /var/lib/arvados/bin/gem list | grep arvados | grep dev | wc -l)" = "0"
does test -z "$(flock $GEMLOCK /var/lib/arvados/bin/gem list | grep arvados | grep dev)"
work?
Instead of cd /usr/src/arvados/sdk/ruby
and then cd -
you can do it in a subshell (cd /usr/src/arvados/sdk/ruby && ...)
and you don't need the cd -
Updated by Lucas Di Pentima about 2 years ago
Updates at 9e764431d
Test run: developer-run-tests: #3350
- Improves code style
- Improves
arvados
gem pattern matching
Updated by Lucas Di Pentima about 2 years ago
WB integration tests re-run: developer-run-tests-apps-workbench-integration: #3599
Updated by Peter Amstutz about 2 years ago
Lucas Di Pentima wrote in #note-7:
WB integration tests re-run: developer-run-tests-apps-workbench-integration: #3599
LGTM
Updated by Lucas Di Pentima about 2 years ago
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
Applied in changeset arvados|78a6558918cbc38d01907682d480602a1351fa97.