Arvados

I checked whether this has been addressed upstream and the answer is no. There has been no development since my last PR. This is what I expected but I had to be 100% sure. We're on our own.

22972-pgdg-keyring-fix - commit 9c894d0d (postgres-formula at github)
22972-salt-installer-pgdg-keyring - 34ac7fc6 (arvados repo)

test-provision: #1224

• All agreed upon points are implemented / addressed. Describe changes from pre-implementation design.
  • Yes, we switched back to using upstream PG packages by default with this change, as we're able to use apt.postgresql.org package sources again.
• Anything not implemented (discovered or discussed during work) has a follow-up story.
  • Ubuntu 24.04 support was left as a future exercise. We probably won't be adding it to this version of the installer. As a result, the test-provision-ubuntu2404 job has been disabled for now.
• Code is tested and passing, both automated and manual, what manual testing was done is described.
  • Yes. I've also manually tested it by deploying a Debian 12 multi-node cluster.
• New or changed UI/UX has gotten feedback from stakeholders.
  • N/A
• Documentation has been updated.
  • N/A
• Behaves appropriately at the intended scale (describe intended scale).
  • No changes in scale
• Considered backwards and forwards compatibility issues between client and server.
  • N/A
• Follows our coding standards and GUI style guidelines.
  • N/A

Changes¶

• Fixes postgres-formula so that it correctly downloads & installs the GPG pubkey file where apt looks for it and doesn't attempt to install the no longer available pgdg-keyring package.
• Updates the provision script to use the new PG formula version.

Lucas Di Pentima wrote in #note-6:

22972-pgdg-keyring-fix - commit 9c894d0d (postgres-formula at github)
22972-salt-installer-pgdg-keyring - 34ac7fc6 (arvados repo)

All of this is good to merge.

• Anything not implemented (discovered or discussed during work) has a follow-up story.
  • Ubuntu 24.04 support was left as a future exercise. We probably won't be adding it to this version of the installer. As a result, the test-provision-ubuntu2404 job has been disabled for now.

This is not what I expected based on our conversation. What I expected was that test-provision-ubuntu2404 would continue running with its current configuration; i.e., we would set it up to run with use_upstream_repo: false.

Let's start with the fundamentals. What is the specific issue(s) that prevents the Salt installer from working on Ubuntu 24.04?

A while back I did a branch that I apparently thought would add Ubuntu 24.04 support to the formula. Is that all we need? If you add that commit to your branch, does that get test-provision-ubuntu2404 working normally? It's literally just one line, and I've already written it, so if that's all we need that's fine to do.

Thanks.