Task #3158
closed
Story #2985: [Workbench] Workbench usability and feature improvements
Review 2985-shared-projects-descriptions
100%
Description
Review for commit ae7e9e24:
Project descriptions in the "My Projects" and "Projects shared with me" panels are displayed inline next to the project name, not in a tooltip.
Updated by Tim Pierce over 10 years ago
- Description updated (diff)
- Assigned To set to Radhika Chippada
- Estimated time set to 0.50 h
- Remaining (hours) set to 0.5
Updated by Radhika Chippada over 10 years ago
- Status changed from New to In Progress
- Assigned To changed from Radhika Chippada to Tim Pierce
Everything functions correctly, but just one concern about real estate.
If I have a project with name containing 5 or 6 words, it wraps even if it is the very first in the hierarchy. And, I would think this would be the most common use case? Should we allocate 50% space for name and 50% to description to minimize wrapping?
I am also wondering what purpose the folder icon to the left of each project name serving in the “My projects” and “Projects shared with me” panels. They all have the same icon and hence I think they are redundant. May be we can get rid off them and make more room for the name? The project name is of different font style and color and hence I think would be clear to see even without the icon.
Other than that, the code itself is good and can be merged as is. Thanks.
Updated by Radhika Chippada over 10 years ago
Alternative suggestion: May be we can display Name and description next to each other, rather than as two different grid elements. Name would have bigger font, color and styling and description with the smaller font right next to it, rather than as a separate grid element.
Updated by Tim Pierce over 10 years ago
Great questions. For now I'm going to defer to what Tom said on IRC:
- 17:12 <tomclegg> don't overthink this - until we ask for / look at tom o.'s version of a given piece of UI it's generally not a good investment to tweak things to make them nice.
- 17:13 <tomclegg> if we get to the point "see, each project has a description!" then it'll be easier for him/users to tell us better ways to present it.
So since you're okay with the code I'm going to go ahead and merge -- I think maybe we do want to remove the folder icon or give the project name more space, but those seem like some of the questions that we want Tom O. to figure out.
Updated by Tim Pierce over 10 years ago
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
- Remaining (hours) changed from 0.5 to 0.0
Applied in changeset arvados|commit:10071dfd716b0131dfd5cd6d782422beef950f61.